[stable-33.0] fix(file-provider): detect lock changes during working set enumeration.#10026
Merged
Conversation
Nextcloud file locking does not update etags, so the previous optimisation that skipped child directories with unchanged etags silently hid lock state changes on nested files. Only skip directories that are both unchanged and have no materialised descendants. Also preserve lockToken and visitedDirectory in the target depth read path, matching the other two code paths. Signed-off-by: Camila Ayres <hello@camilasan.com>
Add simple unit test for isInSameDatabaseStoreableRemoteState. Use unique identifiers in lockToken test. Set creationDate in toNKFile() to match toItemMetadata(). Signed-off-by: Camila Ayres <hello@camilasan.com>
backportbot
Bot
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
backportbot
Bot
added
bug
os: 🍎 macOS
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10026.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
camilasan
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10002