feat(UI): Updated settings dialog UI#10031
Conversation
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| private: | ||
| void initStyleOption(QStyleOptionToolButton *option) const |
There was a problem hiding this comment.
annotate this function with override or (rarely) final
| void initStyleOption(QStyleOptionToolButton *option) const | |
| void initStyleOption(QStyleOptionToolButton *option) const override |
Signed-off-by: Rello <Rello@users.noreply.github.com>
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-10031.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
From the screenshots:
- Some of the settings seem to be translated, but some not. Was this already the case or did this break it?
- Where does the style of toggle switches come from? It's inconsistent with how it looks for virtual files. If it's custom, it would be good to make them look like how our switches look on the web anyway, or if not, get it to be consistent with virtual files.
- It would be good if the alignment of classic sync could be fixed as well (and also the gap between the title and description of virtual files, and the text clipping there).
The rest looks like improvements, a good next step.
2 participants
#9979