feat(gui): improve CLI help output and argument validation#10069
Open
joshtrichards wants to merge 8 commits into
Open
feat(gui): improve CLI help output and argument validation#10069joshtrichards wants to merge 8 commits into
joshtrichards wants to merge 8 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
showHint() calls exit itself. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-10069.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Make the GUI's command-line interface easier to use by improving the help text and tightening argument parsing.
Changes
--helpoutput into clearer grouped sectionsparseOptions()parseOptions()with small local helpers--logexpirevalues instead of silently treating them as0--reverseand--overridelocaldirNotes
AccountSetupCommandLineManageris unchanged--logexpirevalidationFollow-up
Potential follow-ups kept out of this PR:
--reverseshould set RTL unconditionally--overridelocaldir--should be accepted--backgrounddoes and does not do and set expectations accordingly in the help text/etc and address [Bug]:--backgroundnot working #5916Checklist
AI (if applicable)