fix: sync engine readonly folder file deletion#10226
Conversation
|
I'll look at the test failure.. |
b3836a7 to
18bfc50
Compare
|
I've made the code distinct between totally new file and move of existing file from same sync folder to the readonly dir. I've also enabled the PermissionsTest on MacOS since they now all pass on my machine. Let's see if the CI sees it differently? (I also rebased on master) |
This is for nextcloud#7797 and nextcloud#10099 Signed-off-by: Markus Goetz <markus@woboq.com> Assisted-by: ClaudeCode:claude-opus-4-8
|
Artifact containing the AppImage: nextcloud-appimage-pr-10226.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Tested OK on my setup (binary built on commit a910031 on a Debian unstable and using a kinda "custom" NC server): the Desktop Client patched with the content of this MR behaves exactly as told. |
|
CI failure seems unrelated: |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Resolves
This is for #7797 and #10099
It would probably be good to backport this (if it's the correct fix and is merged...)
Summary
Show stray file in UI instead of agressively deleting it (= potential data loss)
Checklist
AI (if applicable)