feature: add search dialog to new tray menu#10331
Open
Rello wants to merge 3 commits into
Open
Conversation
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Rello
added
os: 🍎 macOS
Collaborator
Author
|
/backport to stable-34.0 |
Signed-off-by: Rello <github@scherello.de>
Expose isFetchMoreInProgress, hasSearchTerm, hasSearchError, canEditSearch and a computed SearchState enum as model properties, replacing the derived booleans in SearchWindow.qml. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
Add cases for placeholder, skeleton, results, nothing found and search error states, plus the derived boolean properties. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
feature/SearchDialog
branch
from
4b74b96 to
d7b44af
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10331.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: double "search" in the header was removed after the screenshot