Skip to content

Commit 513c538

Browse files
docs(design): address barth's comments
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: Nimisha Vijay <52440189+nimishavijay@users.noreply.github.com>
1 parent 79f35c9 commit 513c538

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

developer_manual/design/components.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ initials otherwise, and a generic icon for non-users like external email address
7070

7171
- User avatars are the default and automatically show the user's profile picture and status. Use them whenever you have a real Nextcloud user.
7272
- Non-user avatars represent external email addresses, guests, and integrations. For example, external recipients in Mail and guests in Talk.
73-
- 32px as the default size for avatars, but they can be as small as 24px in dense lists, , and as large as 44-64px in headers and profile cards. Keep the size consistent within a single list or row.
73+
- 32px as the default size for avatars, but they can be as small as 24px in dense lists, and as large as 44-64px in headers and profile cards. Keep the size consistent within a single list or row.
7474

7575
- Avoid placing an avatar alone in flowing text without a name next to it. For inline mentions of a user inside a sentence, use a User bubble.
7676

@@ -250,12 +250,12 @@ file type, picking one or several items, and choosing folders.
250250
.. _Checkboxes and toggles:
251251

252252
Checkboxes and toggles
253-
--------------------------------------
253+
----------------------
254254

255255
Checkboxes and toggles `(NcCheckboxRadioSwitch) <https://nextcloud-vue-components.netlify.app/#/Components/NcCheckboxRadioSwitch>`__ are selection controls that share a
256256
single component.
257257

258-
- Checkboxes allow users to select multiple options from a list. for example, per-folder share permissions.
258+
- Checkboxes allow users to select multiple options from a list. For example, per-folder share permissions.
259259
- Toggles (switches) are used for enabling and disabling a single setting.
260260

261261

@@ -271,7 +271,7 @@ single component.
271271
Radio groups
272272
^^^^^^^^^^^^
273273

274-
Radio buttons allow users to select exactly one option from a defined radio group `(NcRadioGroup) <https://nextcloud-vue-components.netlify.app/#/Components/NcRadioGroup>`__ . It also has a button variant which displays the options as buttons. When there are many options, use a dropdown instead.
274+
Radio buttons allow users to select exactly one option from a defined radio group `(NcRadioGroup) <https://nextcloud-vue-components.netlify.app/#/Components/NcRadioGroup>`__. It also has a button variant which displays the options as buttons. When there are many options, use a dropdown instead.
275275

276276
.. image:: ../images/radio-group.png
277277
:alt: Radio group Mail settings

developer_manual/design/introduction.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ Each Nextcloud app is unique and different, but all Nextcloud apps are built kee
2121
color and iconography.
2222
- The state of the application should be clear. If something loads, provide feedback. Reactions should be quick, ideally under 100ms as per `response time
2323
limits <https://www.nngroup.com/articles/response-times-3-important-limits/>`__.
24-
- The state of the application should be clear. If something loads, provide feedback.
2524
- Regularly reset your installation to see what the first-run experience is like, and improve it.
2625
- Ideally do `usability testing <https://jancborchardt.net/usability-in-free-software>`__ to know how people use the software. Testing with 5 users is enough to identify most of your problems.
2726

0 commit comments

Comments
 (0)