Skip to content

Commit c509ed4

Browse files
feat(developermanual): move new and deprecated APIs to dedicated pages
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
1 parent 08ebcfe commit c509ed4

7 files changed

Lines changed: 69 additions & 40 deletions

File tree

developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_34.rst

Lines changed: 6 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,16 @@
1+
.. _upgrade_to_34:
2+
13
=======================
24
Upgrade to Nextcloud 34
35
=======================
46

7+
..
8+
Add one section for each change.
9+
Only list changes absolutely necessary to keep an app running. Use the dedicated deprecation and new features pages for optional changes and announcements.
10+
511
Front-end changes
612
-----------------
713

8-
Added APIs
9-
^^^^^^^^^^
10-
11-
- TBD
12-
13-
Changed APIs
14-
^^^^^^^^^^^^
15-
16-
- TBD
17-
18-
Deprecated APIs
19-
^^^^^^^^^^^^^^^
20-
21-
- TBD
22-
2314
Removed APIs
2415
^^^^^^^^^^^^
2516

@@ -47,29 +38,6 @@ Removed APIs
4738
Back-end changes
4839
----------------
4940

50-
Added Events
51-
^^^^^^^^^^^^
52-
53-
- TBD
54-
55-
Added APIs
56-
^^^^^^^^^^
57-
58-
- ``\OCP\DB\QueryBuilder\ITypedQueryBuilder`` is added in favour of ``\OCP\DB\QueryBuilder\IQueryBuilder`` and can be accessed through ``\OCP\IDBConnection::getTypedQueryBuilder``.
59-
This query builder has the benefit of accurately returning the selected columns in a query result, increasing type safety.
60-
- ``\OCP\Talk\IConversationOptions`` has been extended, to allow defining the newly created conversation as related to a meeting with it's start and end date.
61-
The information is used by Talk to automatically clean up such conversations after a given time.
62-
63-
Changed APIs
64-
^^^^^^^^^^^^
65-
66-
- ``\OCP\Notification\INotification::setIcon``, ``\OCP\Notification\INotification::setLink`` and ``\OCP\Notification\IAction::setLink`` now throw ``\OCP\Notification\InvalidValueException`` when the provided link is not absolute as previously announced in :doc:`./upgrade_to_30`
67-
68-
Deprecated APIs
69-
^^^^^^^^^^^^^^^
70-
71-
- TBD
72-
7341
Removed APIs
7442
^^^^^^^^^^^^
7543

developer_manual/basics/storage/database.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
.. _database:
2+
13
===============
24
Database access
35
===============

developer_manual/index.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Table of contents
1515
:maxdepth: 2
1616

1717
prologue/index
18+
release_notes/index
1819
getting_started/index
1920
basics/index
2021
app_development/index

developer_manual/prologue/compatibility_app_ecosystem.rst

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,18 @@ There are three procedures in place to facilitate communication to app developer
2020

2121
This means the development of your pull request cannot be considered done if you introduced changes (additions, removals or modifications) that affect app developers that you did not document.
2222

23-
2. A change that affects app developers, has to be reported and documented by the author of the pull request in the :ref:`App Upgrade guide <app-upgrade-guide>` section.
23+
2. A change necessary for app developers to execute for app compatibility in a new version, has to be reported and documented by the author of the pull request in the :ref:`App Upgrade guide <app-upgrade-guide>` section.
2424

2525
The requirements for this documentation are:
2626

2727
- It should be written so that app developers understand how to work around the change for their app in a tutorial format
2828
- The steps should be explicitly written, so the documentation shall not rely upon links to external resources for the steps. While it is encouraged to add an external links as additional reference, it is a hard requirement that the documentation is readable and actionable without browsing to this link.
2929
- The change author's name should be added to the section so readers can reach out to the author if they have questions or if something is unclear.
3030
- Timeline: the documentation is required to be handed in when finalizing the pull request and should be merged timely close to the actual change.
31-
31+
32+
3. New APIs are advertised at :ref:`new-apis` but need a dedicated documentation section.
33+
34+
4. Deprecations are collected at :ref:`deprecated-apis`.
3235

3336
Other documentation requirements
3437
--------------------------------
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
.. _deprecated-apis:
2+
3+
============
4+
Deprecations
5+
============
6+
7+
In order to improve our platform we are phasing out some APIs. Deprecated APIs are not removed before ???,
8+
unless the breakage can not be avoided.
9+
10+
We highly recommend using the `Nextcloud Rector <https://packagist.org/packages/nextcloud/rector>`_
11+
rules, which can fix some API changes automatically.
12+
13+
..
14+
Add one section for each group of deprecations (e.g. group files api changes, authentication changes).
15+
Also deprecate the feature at their dedicated documentation page.
16+
After branch-off the contents below will be cleared.
17+
18+
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
=============
2+
Release notes
3+
=============
4+
5+
This section is for developers and maintainers who are familiar with an earlier version of the documentation.
6+
7+
Here we try to summarize what's new. You will find the breaking changes at :ref:`upgrade_to_34`, new deprecations at :ref:`deprecated-apis` and new API features at :ref:`new-apis`.
8+
9+
.. toctree::
10+
:maxdepth: 3
11+
12+
new
13+
deprecations
14+
../app_publishing_maintenance/app_upgrade_guide/upgrade_to_34
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
.. _new-apis:
2+
3+
===================
4+
New in this release
5+
===================
6+
7+
This pages covers new features of the platform.
8+
9+
..
10+
Add one section for each new feature.
11+
Every feature should just have a brief description. Details have to be documented on a dedicated, persistent page.
12+
After branch-off the contents below will be cleared.
13+
14+
Typed query builder
15+
-------------------
16+
17+
``\OCP\DB\QueryBuilder\ITypedQueryBuilder`` was added in favour of ``\OCP\DB\QueryBuilder\IQueryBuilder`` and can be accessed through ``\OCP\IDBConnection::getTypedQueryBuilder``.
18+
19+
This query builder has the benefit of accurately returning the selected columns in a query result, increasing type safety.
20+
21+
.. todo:: This linked page does not have coverage for the new API.
22+
23+
See :ref:`database` for details.

0 commit comments

Comments
 (0)