Skip to content

feat: Add deprecations related to hooks and events #14796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Draft

feat: Add deprecations related to hooks and events #14796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions developer_manual/release_notes/critical_changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ Removed front-end APIs and libraries
- ``OC.Files.Client`` as it was extending the ``Backbone``.
- ``Handlebars`` was deprecated and scheduled for removal since Nextcloud 19.

Behavior change in the back-end APIs
------------------------------------

- The hook system (``OC_Hooks::connect`` and ``\OCP\Utils::connectHook``) is
now only accepting a limited amount of signals actually emitted by the server.
As a further steep toward full removal of the hook system.
If you use custom signals in your apps, create custom ``\OCP\EventDispatcher\Event`` instead.


Removed back-end APIs
---------------------
Expand All @@ -64,6 +72,7 @@ Removed back-end APIs
- ``\OCP\AppFramework\Http\StrictContentSecurityPolicy``
- ``\OCP\AppFramework\Http\StrictEvalContentSecurityPolicy``
- ``\OCP\AppFramework\Http\StrictInlineContentSecurityPolicy``
- Various hooks which were deprecated since Nextcloud 21 were removed. This includes ``preCreateUser``, ``postCreateUser``, ``preDelete``, ``postDelete``, ``preSetPassword``, ``postSetPassword``, ``preLogin``, ``postLogin``, ``preRememberedLogin``, ``postRememberedLogin``, ``logout``, ``changeUser`` from ``\OC\User``; ``pre_createUser``, ``post_createUser``, ``pre_deleteUser``, ``post_deleteUser``, ``pre_setPassword``, ``post_setPassword``, ``pre_login``, ``logout``, ``postLogout``, ``changeUser`` from ``OC_User``; ``postDelete`` from ``\OC\Group``. These were replaced by proper events.


Unified sharing
Expand Down
3 changes: 3 additions & 0 deletions developer_manual/release_notes/deprecations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ New deprecations
.. todo:: This page needs a section for every new deprecation.

- The old `OCA\\Files_External::loadAdditionalBackends` generic events was deprecated and is replaced
with a typed event ``OCA\Files_External\Event\LoadAdditionalBackendEvent``.

Older deprecations
------------------

Expand Down
Loading