-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Document IAppManager::getAppNamespace new method #14799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
come-nc
wants to merge
1
commit into
master
Choose a base branch
from
feat/document-iappmanager-getappnamespace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code needs a dedicated section, not just the announcement. We will clear the New in this release page after branch-off. See the other items on this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no existing IAppManager documentation, so one has to be started. I suggest to put it under https://docs.nextcloud.com/server/latest/developer_manual/app_development/index.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what this means.
The existing IAppManager documentation is at https://nextcloud-server.netlify.app/classes/ocp-app-iappmanager
Linked in https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/api.html#php-public-api
Why would we duplicate this in this repository?
I thought that after branch-off this would be moved to release-notes/upgrade_to_34.rst, what is the actual process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class reference is great for diving into details, but it doesn't tell you how and why a class should be used.
Not every app developer is a senior with years of experience with Nextcloud. They don't know how things work just by looking at documentation of classes.
This section was recently reorganized because we only had the diff and not the current state. New will not be moved into a page. We want to get away from this heap of diffs to a comprehensive manual for developers.
I'll try to document this goal better.