fix(a11y): make keyboard focus ring fully visible in navigation#14832
Merged
Conversation
The sidebar nav container uses overflow: hidden, which clips the default outline to only the bottom edge when an item is focused. WCAG 2.4.7 / BITV 9.2.4.7 requires that focus be visible on all sides. Using outline-offset: -2px draws the ring inside the element boundary so it is never clipped by the container. Fixes #9701 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Tue, 12 May 2026 19:30:12 GMT |
skjnldsv
added
2. developing
3. to review
accessibility
and removed
3. to review
2. developing
labels
skjnldsv
requested review from
AndyScherzinger,
jancborchardt,
kra-mo,
marcoambrosini and
susnux
susnux
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Explanations
The sidebar nav container uses
overflow: hidden, so the default browser outline is clipped to one edge — only the bottom line of the focus ring appears, as visible in the issue screenshot. WCAG 2.4.7 / BITV 9.2.4.7 requires that keyboard focus be clearly visible on all sides.Setting
outline-offset: -2pxdraws the outline inward, inside the element boundary, so it is never clipped. Scoped to sidebar nav links, expand buttons, and the version selector toggle.cc @nextcloud/a11y
✅ Checklist
codespellor similar and addressed any spelling issues