fix(a11y): add visible label and search icon to search input#14834
Merged
Conversation
The search input had an aria-label but no visible label and no visual symbol indicating it is a search field, which fails WCAG 3.3.2 / BITV 9.3.3.2 (input fields must be identifiable without relying on placeholder text alone). - Override searchbox.html to add a <label> (visually hidden via .sr-only so the layout is not disrupted) and a FontAwesome magnifying-glass icon positioned inside the input. - Add .sr-only utility class and search icon CSS to custom.css. Fixes #9739 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Tue, 12 May 2026 19:35:38 GMT |
skjnldsv
requested review from
AndyScherzinger,
jancborchardt,
kra-mo and
marcoambrosini
susnux
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Explanations
The search input has an
aria-labelbut no visible label and no visual symbol identifying it as a search field, which fails WCAG 3.3.2 / BITV 9.3.3.2.Changes:
searchbox.htmlto add a<label>element. The label uses the.sr-onlyutility class (visually hidden, still in the accessibility tree) so the layout is unaffected..sr-onlyutility and search icon styles tocustom.css.cc @nextcloud/a11y
✅ Checklist
codespellor similar and addressed any spelling issues