fix(ci): skip unreleased stable branch as deploy target#14886
Merged
Conversation
Mirror the is_version_released() check from build/build-index.php in
the sphinxbuild deploy job. Instead of taking the highest-numbered
stable branch from git refs, iterate descending and check for a
v{N}.0.0 GitHub release tag. First branch with a real release wins.
This prevents a pre-release branch (e.g. stable34 with RC1 only) from
being deployed to server/stable/ on gh-pages.
Signed-off-by: skjnldsv <skjnldsv@proton.me>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
github-actions
Bot
added
github_actions
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Tue, 19 May 2026 09:33:38 GMT |
miaulalala
approved these changes
May 19, 2026
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fixes stable34 (RC-only) being incorrectly deployed as
server/stable/on gh-pages while v34.0.0 is not yet released.What changed and why
The
stage-and-checkjob was picking the highest-numbered stable branch purely by git ref (sort -n | tail -1), ignoring whether that branch has an actual release.Now mirrors the
is_version_released()check already present inbuild/build-index.php: iterates stable branches descending, queries the GitHub API forv{N}.0.0, and uses the first branch that returns HTTP 200. Branches with only RC tags are skipped.Effect:
stable34(RC1 only)server/stable/server/34/stable33(released)server/33/server/stable/✓🖼️ Screenshots
N/A — CI workflow change only.
✅ Checklist
codespellor similar and addressed any spelling issues