Skip to content

fix: version picker wrong version display and unclear stable label #14891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
skjnldsv wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −9
Draft

fix: version picker wrong version display and unclear stable label #14891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccdcf26
fix: version picker shows wrong version and unclear stable label
skjnldsv May 19, 2026
5e69b4c
fix: remove duplicate stable version from version picker
skjnldsv May 19, 2026
949d78b
fix(versions): show version numbers for latest and stable in brackets
skjnldsv May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions admin_manual/_templates/versions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
data-toggle="rst-current-version"
aria-expanded="false"
aria-controls="rst-other-versions-admin">
☁️ {{ current_version }}
☁️ {% if current_version == 'stable' %}{{ version_stable }} (stable){% elif current_version == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ current_version }}{% endif %}
<span class="fa fa-caret-down" aria-hidden="true"></span>
</button>
<div id="rst-other-versions-admin" class="rst-other-versions">
Expand All @@ -22,7 +22,7 @@
style="color: var(--dark-link-color);"
{% endif %}
>
{{ slug }}
{% if slug == 'stable' %}{{ version_stable }} (stable){% elif slug == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ slug }}{% endif %}
</a>
</dd>
{% endfor %}
Expand Down
7 changes: 4 additions & 3 deletions conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ def setup(app):

def generateVersionsDocs(current_docs):
versions_doc = []
for v in range(version_start, version_stable + 1):
for v in range(version_start, version_stable):
url = 'https://docs.nextcloud.com/server/%s/%s' % (str(v), current_docs)
versions_doc.append(tuple((v, url)))
versions_doc.append(tuple((str(v), url)))
versions_doc.append(tuple(('stable', 'https://docs.nextcloud.com/server/%s/%s' % ('stable', current_docs))))
versions_doc.append(tuple(('latest', 'https://docs.nextcloud.com/server/%s/%s' % ('latest', current_docs))))
return versions_doc
Expand All @@ -93,7 +93,8 @@ def generateVersionsDocs(current_docs):
github_branch = 'master'

html_context = {
'current_version': version,
'current_version': release,
'version_stable': str(version_stable),
'READTHEDOCS': True,

# force github plugin
Expand Down
4 changes: 2 additions & 2 deletions developer_manual/_templates/versions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
data-toggle="rst-current-version"
aria-expanded="false"
aria-controls="rst-other-versions-dev">
☁️ {{ current_version }}
☁️ {% if current_version == 'stable' %}{{ version_stable }} (stable){% elif current_version == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ current_version }}{% endif %}
<span class="fa fa-caret-down" aria-hidden="true"></span>
</button>
<div id="rst-other-versions-dev" class="rst-other-versions">
Expand All @@ -22,7 +22,7 @@
style="color: var(--dark-link-color);"
{% endif %}
>
{{ slug }}
{% if slug == 'stable' %}{{ version_stable }} (stable){% elif slug == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ slug }}{% endif %}
</a>
</dd>
{% endfor %}
Expand Down
4 changes: 2 additions & 2 deletions user_manual/_templates/versions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
aria-controls="rst-other-versions-user">
🌐 {{ language_names.get(language, language) }}
<span class="fa fa-caret-down" aria-hidden="true"></span>
☁️ {{ current_version }}
☁️ {% if current_version == 'stable' %}{{ version_stable }} (stable){% elif current_version == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ current_version }}{% endif %}
<span class="fa fa-caret-down" aria-hidden="true"></span>
</button>
<div id="rst-other-versions-user" class="rst-other-versions">
Expand Down Expand Up @@ -97,7 +97,7 @@
style="color: var(--dark-link-color);"
{% endif %}
>
{{ slug }}
{% if slug == 'stable' %}{{ version_stable }} (stable){% elif slug == 'latest' %}{{ version_stable|int + 1 }} (latest){% else %}{{ slug }}{% endif %}
</a>
</dd>
{% endfor %}
Expand Down
Loading