fix: replace sed -i with perl -pi for macOS compatibility#14990
Open
skjnldsv wants to merge 1 commit into
Open
fix: replace sed -i with perl -pi for macOS compatibility#14990skjnldsv wants to merge 1 commit into
skjnldsv wants to merge 1 commit into
Conversation
macOS BSD sed requires a backup extension with -i (e.g. sed -i ''), while GNU sed does not accept an empty extension. The merge-folders target used sed -i -e which fails on macOS with: sed: 1: "<file>": invalid command code . Replace with perl -pi -e which is portable across both platforms. Fixes #13186 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Thu, 21 May 2026 11:03:04 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Summary
merge-foldersinuser_manual/Makefileusedsed -i -eto rewrite_imagesand_staticpaths in the built HTML. macOS BSD sed requiresa backup-extension argument with
-i(e.g.sed -i ''), while GNU seddoes not accept an empty extension — there is no single flag spelling
that works on both.
Replace both invocations with
perl -pi -e, which handles in-placeedits portably on Linux and macOS.
Before:
find ./ -type f -exec sed -i -e 's/_images/..\/_images/g' {} \; find ./ -type f -exec sed -i -e 's/_static/..\/_static/g' {} \;After:
find ./ -type f -exec perl -pi -e 's|_images|../_images|g' {} \; find ./ -type f -exec perl -pi -e 's|_static|../_static|g' {} \;🖼️ Screenshots
N/A — Makefile change only, no visual output affected.
✅ Checklist
codespellor similar and addressed any spelling issues