[stable33] fix: 🐛 Update pdf save to use correct dav path and credentials#1440
Merged
Conversation
Use /public.php/dav/files/SHARING_TOKEN instead of the legacy /public.php/webdav endpoint for public share uploads. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This should not happen, but if it does, it should throw to avoid silently resolving to "/files/undefined" and hiding the error. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Inline getUserRoot into getRootPath so both public and private paths are resolved in one place. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
requesttoken is for CSRF protection and is only meaningful when there is an authenticated session. Public share uploads authenticate via the token in the URL path, so the header is not needed there. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
danxuliu
force-pushed
the
backport/1414/stable33
branch
from
f54b38d to
0de6581
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1414