Ci/phpstan#695
Open
nickvergessen wants to merge 5 commits into
Open
Conversation
Member
nickvergessen
commented
Jan 2, 2025
nickvergessen
commented
nickvergessen
force-pushed
the
ci/phpstan
branch
from
b182c24 to
786ac4b
Compare
nickvergessen
force-pushed
the
ci/phpstan
branch
2 times, most recently
from
90a58f7 to
acb108b
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Comment on lines
69
to
82
| @@ -75,6 +76,7 @@ public function testAddRetentionInvalidTimeUnit(): void { | |||
| } | |||
|
|
|||
| public function testAddRetentionInvalidTimeAmount(): void { | |||
| $this->markTestSkipped('Test is no longer applicable as the Dispatcher is limiting values'); | |||
| $response = $this->api->addRetention(42, 3, 128_000); | |||
| $this->assertSame(Http::STATUS_BAD_REQUEST, $response->getStatus()); | |||
| } | |||
Member
There was a problem hiding this comment.
These can be removed now, right?
Comment on lines
-157
to
+147
| * @return DataResponse<Http::STATUS_NO_CONTENT|Http::STATUS_NOT_FOUND, list<empty>, array{}> | ||
| * @return DataResponse<Http::STATUS_NO_CONTENT|Http::STATUS_NOT_FOUND, array{}, array{}> |
Member
There was a problem hiding this comment.
This should stay list<empty>
Comment on lines
-89
to
+92
| * @param 0|1|2|3 $timeunit Time unit of the retention (days, weeks, months, years) | ||
| * @param int<0, 3> $timeunit Time unit of the retention (days, weeks, months, years) | ||
| * @psalm-param Constants::UNIT_* $timeunit | ||
| * @param positive-int $timeamount Amount of time units that have to be passed | ||
| * @param 0|1 $timeafter Whether retention time is based creation time (0) or modification time (1) | ||
| * @param int<1, 32000> $timeamount Amount of time units that have to be passed | ||
| * @param int<0, 1> $timeafter Whether retention time is based creation time (0) or modification time (1) |
Member
There was a problem hiding this comment.
Not so happy about converting enums to ranges :/ This makes the specifications worse and clients that generate code from it, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.