fix: Do not show generic success message from file list#451
Open
danxuliu wants to merge 1 commit into
Open
Conversation
When an action is executed and it returns a boolean value the file list shows a generic "Done" or "Failed" message for the action. The "Compress to Zip" action only creates the background job that, later, will actually compress the files, so showing "Done" can be confusing for the user if the zip is not already available. Moreover, the action shows its own success message with more information. Due to all that now the generic success message from the file list is no longer shown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
susnux
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an action is executed and it returns a boolean value the file list shows a generic done or failed message for the action (and the same is done for batch actions of several files in the header). The
Compress to Zipaction only creates the background job that, later, will actually compress the files, so showingCompress to Zip: donecan be confusing for the user if the zip is not already available. Moreover, the action shows its own success message with more information. Due to all that now the generic success message from the file list is no longer shown.How to test (scenario 1)
Compress to ZipCompressResult with this pull request
Only
Creating Zip archive started. We will notify you as soon as the archive is available.message is shownResult without this pull request
Both
Creating Zip archive started. We will notify you as soon as the archive is available.andCompress to Zip: donemessages are shownHow to test (scenario 2)
Compress to ZipCompressResult with this pull request
Only
Creating Zip archive started. We will notify you as soon as the archive is available.message is shownResult without this pull request
Both
Creating Zip archive started. We will notify you as soon as the archive is available.andCompress to Zip: donemessages are shown