fix(e2e): revert App.vue changes, fix tests without app-level workarounds

- Revert src/views/App.vue to original state (always start at intro animation)
- Fix 'opens when a new major version' test: click Skip to advance past intro
- Move 'About & What's new' wizard test from settings.spec.ts to firstrunwizard.spec.ts
- Remove 'About & What's new' describe block from settings.spec.ts

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/46619e35-ecf5-4089-a682-8830bd9abfe6

Author: Copilot

e2e/firstrunwizard.spec.ts

@@ -39,14 +39,57 @@ test.describe('First Run Wizard', () => {
 			const wizard = page.locator('.first-run-wizard')
 			await expect(wizard).toBeVisible()
 
-			// In changelog-only mode the intro animation is skipped and the
-			// wizard opens directly on the "What's new" page.
+			// The intro animation is always shown first; skip it to advance
+			// directly to the "What's new" page (changelog-only mode).
+			const skipButton = wizard.getByRole('button', { name: 'Skip' })
+			await expect(skipButton).toBeVisible({ timeout: 5_000 })
+			await skipButton.click()
+
+			// In changelog-only mode the wizard advances directly to the
+			// "What's new" page after the intro animation.
 			await expect(wizard).toContainText('New in Nextcloud Hub')
 		} finally {
 			await deleteUser(user.userId)
 		}
 	})
 
+	test('"About & What\'s new" menu entry reopens the wizard', async ({ page }) => {
+		const user = await createRandomUser()
+
+		try {
+			await login(page, user.userId, user.password)
+
+			// Close the first-run wizard that opens automatically on first login
+			const wizard = page.locator('.first-run-wizard')
+			await expect(wizard).toBeVisible()
+
+			// Skip the intro animation as soon as the Skip button appears (~2s)
+			const skipButton = wizard.getByRole('button', { name: 'Skip' })
+			await expect(skipButton).toBeVisible({ timeout: 5_000 })
+			await skipButton.click()
+
+			// Close the slideshow
+			const closeButton = wizard.getByRole('button', { name: 'Close' })
+			await expect(closeButton).toBeVisible()
+			await closeButton.click()
+			await expect(wizard).not.toBeVisible()
+
+			// Open the user settings menu to find the "About & What's new" entry
+			const userMenu = page.locator('[aria-controls="header-menu-user-menu"]')
+			await userMenu.click()
+
+			// Use the link role to avoid strict mode violation from the duplicate ID
+			// that Nextcloud renders on both the <li> and the inner <a> element
+			const aboutEntry = page.getByRole('link', { name: "About & What's new" })
+			await aboutEntry.click()
+
+			// The wizard should open again via the app-menu.ts handler
+			await expect(wizard).toBeVisible()
+		} finally {
+			await deleteUser(user.userId)
+		}
+	})
+
 	test('can be navigated and closed', async ({ page }) => {
 		const user = await createRandomUser()
 

e2e/settings.spec.ts

@@ -44,46 +44,3 @@ test.describe('Settings page', () => {
 		).toBeVisible()
 	})
 })
-
-test.describe('"About & What\'s new" navigation entry', () => {
-	let user: User
-
-	test.beforeAll(async () => {
-		user = await createRandomUser()
-	})
-
-	test.afterAll(async () => {
-		await deleteUser(user.userId)
-	})
-
-	test('opens the first run wizard', async ({ page }) => {
-		await login(page, user.userId, user.password)
-
-		// Close the first-run wizard that opens automatically on first login
-		const wizard = page.locator('.first-run-wizard')
-		await expect(wizard).toBeVisible()
-
-		// Skip the intro animation as soon as the Skip button appears (~2s)
-		const skipButton = wizard.getByRole('button', { name: 'Skip' })
-		await expect(skipButton).toBeVisible({ timeout: 5_000 })
-		await skipButton.click()
-
-		// Close the slideshow
-		const closeButton = wizard.getByRole('button', { name: 'Close' })
-		await expect(closeButton).toBeVisible()
-		await closeButton.click()
-		await expect(wizard).not.toBeVisible()
-
-		// Open the user settings menu to find the "About & What's new" entry
-		const userMenu = page.locator('[aria-controls="header-menu-user-menu"]')
-		await userMenu.click()
-
-		// Use the link role to avoid strict mode violation from the duplicate ID
-		// that Nextcloud renders on both the <li> and the inner <a> element
-		const aboutEntry = page.getByRole('link', { name: "About & What's new" })
-		await aboutEntry.click()
-
-		// The wizard should open again via the app-menu.ts handler
-		await expect(wizard).toBeVisible()
-	})
-})

src/views/App.vue

@@ -24,8 +24,7 @@ const showChangelogOnly = loadState<boolean>('firstrunwizard', 'changelogOnly',
 const changelogPage = Math.max(pages.findIndex((page) => page.id === 'whats-new'), 0)
 
 const showModal = ref(false)
-/** Start directly at the changelog page for returning users who only need to see the changelog */
-const currentPage = ref(showChangelogOnly ? changelogPage : -1)
+const currentPage = ref(-1)
 const setReturnFocus = ref<HTMLElement | SVGElement | string>()
 
 /**
@@ -35,8 +34,7 @@ const setReturnFocus = ref<HTMLElement | SVGElement | string>()
  */
 function open(focusReturn?: HTMLElement | SVGElement | string) {
 	setReturnFocus.value = focusReturn
-	// Skip the intro animation for returning users who only need the changelog
-	currentPage.value = showChangelogOnly ? changelogPage : -1
+	currentPage.value = -1
 	showModal.value = true
 }