fix: phpunit test with sort()

datapumpernickel · Chartman123 · commit 1896f0189157 · 2026-04-17T22:20:21.000+02:00
Signed-off-by: paul bochtler &lt;65470117+datapumpernickel@users.noreply.github.com&gt;
diff --git a/lib/Service/SubmissionService.php b/lib/Service/SubmissionService.php
@@ -586,7 +586,10 @@ public function validateSubmission(array $questions, array $answers, string $for
 				$optionIds = array_map('intval', array_column($question['options'] ?? [], 'id'));
 				$rankedIds = array_map('intval', $answers[$questionId]);
 
-				if (sort($rankedIds) !== sort($optionIds)) {
+				sort($optionIds);
+				sort($rankedIds);
+
+				if ($rankedIds !== $optionIds) {
 					throw new \InvalidArgumentException(sprintf('Ranking for question "%s" must include all options exactly once.', $question['text']));
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -586,7 +586,10 @@ public function validateSubmission(array $questions, array $answers, string $for`
`586`	`586`	`$optionIds = array_map('intval', array_column($question['options'] ?? [], 'id'));`
`587`	`587`	`$rankedIds = array_map('intval', $answers[$questionId]);`
`588`	`588`
`589`		`- if (sort($rankedIds) !== sort($optionIds)) {`
	`589`	`+ sort($optionIds);`
	`590`	`+ sort($rankedIds);`
	`591`	`+`
	`592`	`+ if ($rankedIds !== $optionIds) {`
`590`	`593`	`throw new \InvalidArgumentException(sprintf('Ranking for question "%s" must include all options exactly once.', $question['text']));`
`591`	`594`	`}`
`592`	`595`	`}`