Skip to content

Commit 1e6568a

Browse files
authored
Merge pull request #3392 from nextcloud/fix/question-reorder-save-on-drop
fix: save question reorder on drop instead of during drag
2 parents 4913926 + 6ea6cba commit 1e6568a

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/components/Questions/QuestionDropdown.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
handle=".option__drag-handle"
5858
invertSwap
5959
target=".sort-target"
60-
@change="saveOptionsOrder('choice')"
60+
@update="dirtyOptionsType = 'choice'"
6161
@start="onDragStart"
6262
@end="onDragEnd">
6363
<TransitionGroup

src/components/Questions/QuestionGrid.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
handle=".option__drag-handle"
102102
invertSwap
103103
target=".sort-target"
104-
@change="saveOptionsOrder('column')"
104+
@update="dirtyOptionsType = 'column'"
105105
@start="onDragStart"
106106
@end="onDragEnd">
107107
<!-- Column input edit -->
@@ -139,7 +139,7 @@
139139
handle=".option__drag-handle"
140140
invertSwap
141141
target=".sort-target"
142-
@change="saveOptionsOrder('row')"
142+
@update="dirtyOptionsType = 'row'"
143143
@start="onDragStart"
144144
@end="onDragEnd">
145145
<TransitionGroup

src/components/Questions/QuestionMultiple.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
handle=".option__drag-handle"
129129
invertSwap
130130
target=".sort-target"
131-
@change="saveOptionsOrder('choice')"
131+
@update="dirtyOptionsType = 'choice'"
132132
@start="onDragStart"
133133
@end="onDragEnd">
134134
<TransitionGroup

src/components/Questions/QuestionRanking.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
handle=".option__drag-handle"
142142
invertSwap
143143
target=".sort-target"
144-
@change="saveOptionsOrder('choice')"
144+
@update="dirtyOptionsType = 'choice'"
145145
@start="onDragStart"
146146
@end="onDragEnd">
147147
<TransitionGroup

src/views/Create.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
direction="vertical"
122122
invertSwap
123123
handle=".question__drag-handle"
124-
@change="onQuestionOrderChange"
124+
@update="onQuestionOrderChange"
125125
@start="onDragStart"
126126
@end="onDragEnd">
127127
<TransitionGroup

0 commit comments

Comments
 (0)