Merge pull request #3500 from josefbehr/fix/empty-keyvaluepairs-error-message

Chartman123 · web-flow · commit 3a0eacb1b432 · 2026-07-16T08:56:38.000+02:00
fix(api): correct misleading error message on empty keyValuePairs
diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php
@@ -675,7 +675,7 @@ public function updateQuestion(int $formId, int $questionId, array $keyValuePair
 		// Don't allow empty array
 		if (count($keyValuePairs) === 0) {
 			$this->logger->info('Empty keyValuePairs, will not update.');
-			throw new OCSBadRequestException('This form is archived and can not be modified');
+			throw new OCSBadRequestException('Empty keyValuePairs, will not update.');
 		}
 
 		//Don't allow to change id or formId

Original file line number	Diff line number	Diff line change
`@@ -675,7 +675,7 @@ public function updateQuestion(int $formId, int $questionId, array $keyValuePair`
`675`	`675`	`// Don't allow empty array`
`676`	`676`	`if (count($keyValuePairs) === 0) {`
`677`	`677`	`$this->logger->info('Empty keyValuePairs, will not update.');`
`678`		`- throw new OCSBadRequestException('This form is archived and can not be modified');`
	`678`	`+ throw new OCSBadRequestException('Empty keyValuePairs, will not update.');`
`679`	`679`	`}`
`680`	`680`
`681`	`681`	`//Don't allow to change id or formId`