fixup! refactor(config): replace IConfig with IAppConfig for improved type safety and clarity

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>

Author: Chartman123

lib/Controller/ConfigController.php

@@ -72,13 +72,15 @@ public function updateAppConfig(string $configKey, mixed $configValue): DataResp
 				} catch (\InvalidArgumentException $e) {
 					return new DataResponse('Invalid value for ' . $configKey, Http::STATUS_BAD_REQUEST);
 				}
+				break;
 
 			case Constants::CONFIG_KEY_CREATIONALLOWEDGROUPS:
 				try {
 					$this->appConfig->setAppValueArray($configKey, $configValue);
 				} catch (\InvalidArgumentException $e) {
 					return new DataResponse('Invalid value for ' . $configKey, Http::STATUS_BAD_REQUEST);
 				}
+				break;
 		}
 
 		return new DataResponse();

tests/Integration/IntegrationBase.php

@@ -33,7 +33,7 @@ class IntegrationBase extends TestCase {
 	public function setUp(): void {
 		parent::setUp();
 
-		$appConfig = \OCP\AppFramework\Services::get(IAppConfig::class);
+		$appConfig = \OCP\Server::get(\OCP\AppFramework\Services\IAppConfig::class);
 		foreach (Constants::CONFIG_KEYS as $key) {
 			$appConfig->deleteAppValue($key);
 		}

tests/Unit/Service/ConfigServiceTest.php

@@ -182,20 +182,20 @@ public static function dataCanCreateForms() {
 		return [
 			'notRestriced' => [
 				'config' => [
-					'restrictCreation' => 'false',
+					'restrictCreation' => false,
 				],
 				'expected' => true
 			],
 			'restrictedGroupAllowed' => [
 				'config' => [
-					'restrictCreation' => 'true',
+					'restrictCreation' => true,
 					'creationAllowedGroups' => '["usersGroup","notUsersGroup"]'
 				],
 				'expected' => true
 			],
 			'restrictedNotInGroup' => [
 				'config' => [
-					'restrictCreation' => 'true',
+					'restrictCreation' => true,
 					'creationAllowedGroups' => '["notUsersGroup"]'
 				],
 				'expected' => false