chore: install rector and run it with empty ruleset

Chartman123 · Chartman123 · commit 6c0d56fb4f74 · 2026-06-10T19:17:48.000+02:00
Signed-off-by: Christian Hartmann &lt;chris-hartmann@gmx.de&gt;
diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php
@@ -335,7 +335,7 @@ public function updateForm(int $formId, array $keyValuePairs): DataResponse {
 		}
 
 		// Process file unlinking
-		if (key_exists('fileId', $keyValuePairs) && key_exists('fileFormat', $keyValuePairs) && !isset($keyValuePairs['fileFormat'])) {
+		if (array_key_exists('fileId', $keyValuePairs) && array_key_exists('fileFormat', $keyValuePairs) && !isset($keyValuePairs['fileFormat'])) {
 			$form->setFileId(null);
 			$form->setFileFormat(null);
 		}
@@ -673,24 +673,24 @@ public function updateQuestion(int $formId, int $questionId, array $keyValuePair
 		}
 
 		// Don't allow empty array
-		if (sizeof($keyValuePairs) === 0) {
+		if (count($keyValuePairs) === 0) {
 			$this->logger->info('Empty keyValuePairs, will not update.');
 			throw new OCSBadRequestException('This form is archived and can not be modified');
 		}
 
 		//Don't allow to change id or formId
-		if (key_exists('id', $keyValuePairs) || key_exists('formId', $keyValuePairs)) {
+		if (array_key_exists('id', $keyValuePairs) || array_key_exists('formId', $keyValuePairs)) {
 			$this->logger->debug('Not allowed to update \'id\' or \'formId\'');
 			throw new OCSForbiddenException('Not allowed to update \'id\' or \'formId\'');
 		}
 
 		// Don't allow to reorder here
-		if (key_exists('order', $keyValuePairs)) {
+		if (array_key_exists('order', $keyValuePairs)) {
 			$this->logger->debug('Key \'order\' is not allowed on updateQuestion. Please use reorderQuestions() to change order.');
 			throw new OCSForbiddenException('Please use reorderQuestions() to change order');
 		}
 
-		if (key_exists('extraSettings', $keyValuePairs) && !$this->formsService->areExtraSettingsValid($keyValuePairs['extraSettings'], $question->getType())) {
+		if (array_key_exists('extraSettings', $keyValuePairs) && !$this->formsService->areExtraSettingsValid($keyValuePairs['extraSettings'], $question->getType())) {
 			throw new OCSBadRequestException('Invalid extraSettings, will not update.');
 		}
 
@@ -829,7 +829,7 @@ public function reorderQuestions(int $formId, array $newOrder): DataResponse {
 
 		// Check if all questions are given in Array.
 		$questions = $this->questionMapper->findByForm($formId);
-		if (sizeof($questions) !== sizeof($newOrder)) {
+		if (count($questions) !== count($newOrder)) {
 			$this->logger->debug('The length of the given array does not match the number of stored questions');
 			throw new OCSBadRequestException('The length of the given array does not match the number of stored questions');
 		}
@@ -1023,13 +1023,13 @@ public function updateOption(int $formId, int $questionId, int $optionId, array
 		}
 
 		// Don't allow empty array
-		if (sizeof($keyValuePairs) === 0) {
+		if (count($keyValuePairs) === 0) {
 			$this->logger->info('Empty keyValuePairs, will not update');
 			throw new OCSForbiddenException('Empty keyValuePairs, will not update');
 		}
 
 		//Don't allow to change id or questionId
-		if (key_exists('id', $keyValuePairs) || key_exists('questionId', $keyValuePairs)) {
+		if (array_key_exists('id', $keyValuePairs) || array_key_exists('questionId', $keyValuePairs)) {
 			$this->logger->debug('Not allowed to update id or questionId');
 			throw new OCSForbiddenException('Not allowed to update id or questionId');
 		}
@@ -1157,7 +1157,7 @@ public function reorderOptions(int $formId, int $questionId, array $newOrder, ?s
 
 		$options = $this->optionMapper->findByQuestion($questionId, $optionType);
 
-		if (sizeof($options) !== sizeof($newOrder)) {
+		if (count($options) !== count($newOrder)) {
 			$this->logger->debug('The length of the given array does not match the number of stored options');
 			throw new OCSBadRequestException('The length of the given array does not match the number of stored options');
 		}
@@ -1925,7 +1925,7 @@ private function checkArchivePermission(Form $form, string $currentUserId, array
 		$isOwner = $currentUserId === $form->getOwnerId();
 
 		// If the request contains 'state' it must be the only key
-		if (sizeof($keyValuePairs) !== 1) {
+		if (count($keyValuePairs) !== 1) {
 			$this->logger->debug('State may only be changed on its own');
 			throw new OCSForbiddenException('State may only be changed on its own');
 		}
@@ -1944,19 +1944,19 @@ private function checkArchivePermission(Form $form, string $currentUserId, array
 	}
 
 	private function isLockingRequest(array $keyValuePairs): bool {
-		return sizeof($keyValuePairs) === 1
+		return count($keyValuePairs) === 1
 			&& array_key_exists('lockedUntil', $keyValuePairs)
 			&& $keyValuePairs['lockedUntil'] === 0;
 	}
 
 	private function isUnlockingRequest(array $keyValuePairs): bool {
-		return sizeof($keyValuePairs) === 1
+		return count($keyValuePairs) === 1
 			&& array_key_exists('lockedUntil', $keyValuePairs)
 			&& is_null($keyValuePairs['lockedUntil']);
 	}
 
 	private function isOwnerTransferRequest(array $keyValuePairs): bool {
-		return sizeof($keyValuePairs) === 1 && key_exists('ownerId', $keyValuePairs);
+		return count($keyValuePairs) === 1 && array_key_exists('ownerId', $keyValuePairs);
 	}
 
 	/**
diff --git a/lib/Controller/ShareApiController.php b/lib/Controller/ShareApiController.php
@@ -252,7 +252,7 @@ public function updateShare(int $formId, int $shareId, array $keyValuePairs): Da
 		}
 
 		// Don't allow empty array
-		if (sizeof($keyValuePairs) === 0) {
+		if (count($keyValuePairs) === 0) {
 			$this->logger->info('Empty keyValuePairs, will not update.');
 			throw new OCSForbiddenException('Empty keyValuePairs, will not update');
 		}
diff --git a/lib/Service/ConfigService.php b/lib/Service/ConfigService.php
@@ -123,7 +123,7 @@ public function canCreateForms(): bool {
 
 		$userGroups = $this->groupManager->getUserGroupIds($this->currentUser);
 		// If array intersection is not empty, user is member of any allowed group.
-		if (sizeof(array_intersect($userGroups, $this->getUnformattedCreationAllowedGroups()))) {
+		if (count(array_intersect($userGroups, $this->getUnformattedCreationAllowedGroups()))) {
 			return true;
 		}
 
diff --git a/rector.php b/rector.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/lib',
+        __DIR__ . '/tests',
+    ])
+    // uncomment to reach your current PHP version
+    // ->withPhpSets()
+    ->withTypeCoverageLevel(0)
+    ->withDeadCodeLevel(0)
+    ->withCodeQualityLevel(0);
diff --git a/tests/Integration/Api/ApiV3Test.php b/tests/Integration/Api/ApiV3Test.php
@@ -827,7 +827,7 @@ public function testCreateNewQuestion(array $expected): void {
 		// Check formId & order
 		$this->assertEquals($this->testForms[0]['id'], $data['formId']);
 		unset($data['formId']);
-		$this->assertEquals(sizeof($this->testForms[0]['questions']), $data['order']);
+		$this->assertEquals(count($this->testForms[0]['questions']), $data['order']);
 		unset($data['order']);
 		unset($data['id']);
 
@@ -1567,7 +1567,7 @@ public static function dataDeleteSingleSubmission() {
 	 * @param array $submissionsExpected
 	 */
 	public function testDeleteSingleSubmission(array $submissionsExpected) {
-		$submissionsExpected['filteredSubmissionsCount'] = $submissionsExpected['filteredSubmissionsCount'] - 1;
+		$submissionsExpected['filteredSubmissionsCount'] -= 1;
 		$resp = $this->http->request('DELETE', "api/v3/forms/{$this->testForms[0]['id']}/submissions/{$this->testForms[0]['submissions'][0]['id']}");
 		$data = $this->OcsResponse2Data($resp);
 
diff --git a/tests/Unit/FormsMigratorTest.php b/tests/Unit/FormsMigratorTest.php
@@ -235,7 +235,7 @@ public function testExport(string $expectedJson) {
 
 		$exportDestination->expects($this->once())
 			->method('addFileContents')
-			->will($this->returnCallback(function ($path, $jsonData) use ($expectedJson) {
+			->will($this->returnCallback(function ($path, $jsonData) use ($expectedJson): void {
 				$this->assertJsonStringEqualsJsonString($expectedJson, $jsonData);
 			}));
 		$this->formsMigrator->export($user, $exportDestination, $output);
diff --git a/vendor-bin/rector/composer.json b/vendor-bin/rector/composer.json
@@ -0,0 +1,6 @@
+{
+    "require-dev": {
+        "rector/rector": "^2.4",
+        "nextcloud/rector": "^0.5.1"
+    }
+}
diff --git a/vendor-bin/rector/composer.lock b/vendor-bin/rector/composer.lock

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ public function updateForm(int $formId, array $keyValuePairs): DataResponse {`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`// Process file unlinking`
`338`		`- if (key_exists('fileId', $keyValuePairs) && key_exists('fileFormat', $keyValuePairs) && !isset($keyValuePairs['fileFormat'])) {`
	`338`	`+ if (array_key_exists('fileId', $keyValuePairs) && array_key_exists('fileFormat', $keyValuePairs) && !isset($keyValuePairs['fileFormat'])) {`
`339`	`339`	`$form->setFileId(null);`
`340`	`340`	`$form->setFileFormat(null);`
`341`	`341`	`}`
`@@ -673,24 +673,24 @@ public function updateQuestion(int $formId, int $questionId, array $keyValuePair`
`673`	`673`	`}`
`674`	`674`
`675`	`675`	`// Don't allow empty array`
`676`		`- if (sizeof($keyValuePairs) === 0) {`
	`676`	`+ if (count($keyValuePairs) === 0) {`
`677`	`677`	`$this->logger->info('Empty keyValuePairs, will not update.');`
`678`	`678`	`throw new OCSBadRequestException('This form is archived and can not be modified');`
`679`	`679`	`}`
`680`	`680`
`681`	`681`	`//Don't allow to change id or formId`
`682`		`- if (key_exists('id', $keyValuePairs) \|\| key_exists('formId', $keyValuePairs)) {`
	`682`	`+ if (array_key_exists('id', $keyValuePairs) \|\| array_key_exists('formId', $keyValuePairs)) {`
`683`	`683`	`$this->logger->debug('Not allowed to update \'id\' or \'formId\'');`
`684`	`684`	`throw new OCSForbiddenException('Not allowed to update \'id\' or \'formId\'');`
`685`	`685`	`}`
`686`	`686`
`687`	`687`	`// Don't allow to reorder here`
`688`		`- if (key_exists('order', $keyValuePairs)) {`
	`688`	`+ if (array_key_exists('order', $keyValuePairs)) {`
`689`	`689`	`$this->logger->debug('Key \'order\' is not allowed on updateQuestion. Please use reorderQuestions() to change order.');`
`690`	`690`	`throw new OCSForbiddenException('Please use reorderQuestions() to change order');`
`691`	`691`	`}`
`692`	`692`
`693`		`- if (key_exists('extraSettings', $keyValuePairs) && !$this->formsService->areExtraSettingsValid($keyValuePairs['extraSettings'], $question->getType())) {`
	`693`	`+ if (array_key_exists('extraSettings', $keyValuePairs) && !$this->formsService->areExtraSettingsValid($keyValuePairs['extraSettings'], $question->getType())) {`
`694`	`694`	`throw new OCSBadRequestException('Invalid extraSettings, will not update.');`
`695`	`695`	`}`
`696`	`696`
`@@ -829,7 +829,7 @@ public function reorderQuestions(int $formId, array $newOrder): DataResponse {`
`829`	`829`
`830`	`830`	`// Check if all questions are given in Array.`
`831`	`831`	`$questions = $this->questionMapper->findByForm($formId);`
`832`		`- if (sizeof($questions) !== sizeof($newOrder)) {`
	`832`	`+ if (count($questions) !== count($newOrder)) {`
`833`	`833`	`$this->logger->debug('The length of the given array does not match the number of stored questions');`
`834`	`834`	`throw new OCSBadRequestException('The length of the given array does not match the number of stored questions');`
`835`	`835`	`}`
`@@ -1023,13 +1023,13 @@ public function updateOption(int $formId, int $questionId, int $optionId, array`
`1023`	`1023`	`}`
`1024`	`1024`
`1025`	`1025`	`// Don't allow empty array`
`1026`		`- if (sizeof($keyValuePairs) === 0) {`
	`1026`	`+ if (count($keyValuePairs) === 0) {`
`1027`	`1027`	`$this->logger->info('Empty keyValuePairs, will not update');`
`1028`	`1028`	`throw new OCSForbiddenException('Empty keyValuePairs, will not update');`
`1029`	`1029`	`}`
`1030`	`1030`
`1031`	`1031`	`//Don't allow to change id or questionId`
`1032`		`- if (key_exists('id', $keyValuePairs) \|\| key_exists('questionId', $keyValuePairs)) {`
	`1032`	`+ if (array_key_exists('id', $keyValuePairs) \|\| array_key_exists('questionId', $keyValuePairs)) {`
`1033`	`1033`	`$this->logger->debug('Not allowed to update id or questionId');`
`1034`	`1034`	`throw new OCSForbiddenException('Not allowed to update id or questionId');`
`1035`	`1035`	`}`
`@@ -1157,7 +1157,7 @@ public function reorderOptions(int $formId, int $questionId, array $newOrder, ?s`
`1157`	`1157`
`1158`	`1158`	`$options = $this->optionMapper->findByQuestion($questionId, $optionType);`
`1159`	`1159`
`1160`		`- if (sizeof($options) !== sizeof($newOrder)) {`
	`1160`	`+ if (count($options) !== count($newOrder)) {`
`1161`	`1161`	`$this->logger->debug('The length of the given array does not match the number of stored options');`
`1162`	`1162`	`throw new OCSBadRequestException('The length of the given array does not match the number of stored options');`
`1163`	`1163`	`}`
`@@ -1925,7 +1925,7 @@ private function checkArchivePermission(Form $form, string $currentUserId, array`
`1925`	`1925`	`$isOwner = $currentUserId === $form->getOwnerId();`
`1926`	`1926`
`1927`	`1927`	`// If the request contains 'state' it must be the only key`
`1928`		`- if (sizeof($keyValuePairs) !== 1) {`
	`1928`	`+ if (count($keyValuePairs) !== 1) {`
`1929`	`1929`	`$this->logger->debug('State may only be changed on its own');`
`1930`	`1930`	`throw new OCSForbiddenException('State may only be changed on its own');`
`1931`	`1931`	`}`
`@@ -1944,19 +1944,19 @@ private function checkArchivePermission(Form $form, string $currentUserId, array`
`1944`	`1944`	`}`
`1945`	`1945`
`1946`	`1946`	`private function isLockingRequest(array $keyValuePairs): bool {`
`1947`		`- return sizeof($keyValuePairs) === 1`
	`1947`	`+ return count($keyValuePairs) === 1`
`1948`	`1948`	`&& array_key_exists('lockedUntil', $keyValuePairs)`
`1949`	`1949`	`&& $keyValuePairs['lockedUntil'] === 0;`
`1950`	`1950`	`}`
`1951`	`1951`
`1952`	`1952`	`private function isUnlockingRequest(array $keyValuePairs): bool {`
`1953`		`- return sizeof($keyValuePairs) === 1`
	`1953`	`+ return count($keyValuePairs) === 1`
`1954`	`1954`	`&& array_key_exists('lockedUntil', $keyValuePairs)`
`1955`	`1955`	`&& is_null($keyValuePairs['lockedUntil']);`
`1956`	`1956`	`}`
`1957`	`1957`
`1958`	`1958`	`private function isOwnerTransferRequest(array $keyValuePairs): bool {`
`1959`		`- return sizeof($keyValuePairs) === 1 && key_exists('ownerId', $keyValuePairs);`
	`1959`	`+ return count($keyValuePairs) === 1 && array_key_exists('ownerId', $keyValuePairs);`
`1960`	`1960`	`}`
`1961`	`1961`
`1962`	`1962`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ public function updateShare(int $formId, int $shareId, array $keyValuePairs): Da`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`// Don't allow empty array`
`255`		`- if (sizeof($keyValuePairs) === 0) {`
	`255`	`+ if (count($keyValuePairs) === 0) {`
`256`	`256`	`$this->logger->info('Empty keyValuePairs, will not update.');`
`257`	`257`	`throw new OCSForbiddenException('Empty keyValuePairs, will not update');`
`258`	`258`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public function canCreateForms(): bool {`
`123`	`123`
`124`	`124`	`$userGroups = $this->groupManager->getUserGroupIds($this->currentUser);`
`125`	`125`	`// If array intersection is not empty, user is member of any allowed group.`
`126`		`- if (sizeof(array_intersect($userGroups, $this->getUnformattedCreationAllowedGroups()))) {`
	`126`	`+ if (count(array_intersect($userGroups, $this->getUnformattedCreationAllowedGroups()))) {`
`127`	`127`	`return true;`
`128`	`128`	`}`
`129`	`129`