Skip to content

chore(QuestionMultiple): update "Other" answer handling to use v-model and add change handler#2689

Merged
Chartman123 merged 1 commit intomainfrom
chore/refactorQuestionMultipleOtherAnswer
Apr 25, 2025
Merged

chore(QuestionMultiple): update "Other" answer handling to use v-model and add change handler#2689
Chartman123 merged 1 commit intomainfrom
chore/refactorQuestionMultipleOtherAnswer

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

Signed-off-by: GitHub noreply@github.com

@Chartman123 Chartman123 added javascript Javascript related ticket 3. to review Waiting for reviews labels Apr 10, 2025
@Chartman123 Chartman123 added this to the 5.2 milestone Apr 10, 2025
@Chartman123 Chartman123 added the technical debt Technical issue label Apr 10, 2025
@Chartman123 Chartman123 self-assigned this Apr 10, 2025
@Chartman123 Chartman123 requested a review from susnux April 10, 2025 14:22
@Chartman123 Chartman123 force-pushed the chore/refactorQuestionMultipleOtherAnswer branch from bb31c78 to 63bc9c4 Compare April 10, 2025 21:39
@Chartman123 Chartman123 requested a review from hamza221 April 15, 2025 08:16
Comment thread src/components/Questions/QuestionMultiple.vue Outdated
Comment thread src/components/Questions/QuestionMultiple.vue Outdated
Copy link
Copy Markdown
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just remove one of both then, no?

@Chartman123
Copy link
Copy Markdown
Collaborator Author

we can just remove one of both then, no?

Yes, makes sense, good catch! I must have overlooked that...

@Chartman123 Chartman123 force-pushed the chore/refactorQuestionMultipleOtherAnswer branch from 63bc9c4 to 4af16e1 Compare April 16, 2025 11:49
…odel and add change handler

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: GitHub <noreply@github.com>
@Chartman123 Chartman123 force-pushed the chore/refactorQuestionMultipleOtherAnswer branch from 4af16e1 to 0795495 Compare April 16, 2025 11:50
@Chartman123 Chartman123 requested a review from susnux April 16, 2025 11:50
@Chartman123 Chartman123 merged commit c665ff4 into main Apr 25, 2025
47 checks passed
@Chartman123 Chartman123 deleted the chore/refactorQuestionMultipleOtherAnswer branch April 25, 2025 10:11
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable5

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jun 25, 2025
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews javascript Javascript related ticket technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants