Add pagination for submissions

[Koc]

This PR adds pagination for submissions list page. Few notes about implementation:

• It's not affect "Summary" tab
• Pagination works on the server
• There is an extra "search" field that used for filtering submissions

🔍 Preview

[Chartman123]

Hi @Koc

nice start, here are a few comments:

• I think we should split up the filtering from the rest of the pagination block and move it up to the right of the summary/responses switch
  
• The page dropdown is placed too high, there should be more spacing on top of it
• floating style looks odd to me, should be just embedded into the page
• page selection should be below the submissions or above and below but not only above them.
• A max of 50 items seems too big for me as a default. You'd still have to scroll a lot before you reach the end of the page
• At best we should make the item limit configurable (user setting)

Regarding the pagination in general: I think we should only fetch the currently shown submissions from the API. But in this case the filtering will no longer be able to work only in the front-end. So more adjustments needed then...

[Koc]

Hey @Chartman123 , thank you for quick feedback, very appreciated!

I've did some changes and updated screenshots in the PR description. So, I've moved pagination to backend and added extra parameter for full text search. For some reason it not works for me 😕 . Please help, feel free to push.

[codecov]

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.54%. Comparing base (de7971b) to head (bacb41f).
Report is 16 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2710      +/-   ##
============================================
+ Coverage     44.49%   45.54%   +1.05%     
- Complexity      974      977       +3     
============================================
  Files            79       79              
  Lines          3531     3548      +17     
============================================
+ Hits           1571     1616      +45     
+ Misses         1960     1932      -28     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Chartman123]

submissionCount is now part of the Form, you can just rely on it. I needed it for the allowEditSubmission PR :)

[Koc]

@Chartman123 mate, the problem is that we have 2 different counts. That's the reason why I'm using another property. BTW thanx for SQLite fix!

[Chartman123]

@Koc ah yes you're right... 🙈

[Chartman123]

But your count is wrong at the moment for shared forms:

You're counting all submissions and not only those by the current user if the user doesn't have the see all results permission

[Koc]

We have green pipeline finally! 🎉

Also I've replaced shitty unit test for SubmissionMapper with a proper integration test that reads real data from db without mocking.

[Chartman123]

Count looks good now :) But I'm not happy with the name totalSubmissionsCount as it's not the total of all submissions available to the user. What about renaming it to filteredSubmissionsCount?

And the search box is not properly aligned to the other items in the block. You could also use the var(--default-grid-baseline) for the margin instead of the 4px.

[Koc]

@Chartman123 done ✔️

[Chartman123]

Two more little comments, but rest looks fine for me :)

I posted this PR to Design team chat and asked if someone could have a look at it design-wise...

[jancborchardt]

Looks good! Just 2 comments:

Usually the pagination element is on the bottom of the oage rather than the top. It can be made sticky on the bottom if wanted.

At best we should make the item limit configurable (user setting)

@Chartman123 just for info – something unimportant as this should not be a setting but instead have a proper value, as per design guidelines. :)

[Chartman123]

@jancborchardt Thanks for the review 👍🏻

Usually the pagination element is on the bottom of the oage rather than the top.

@Koc could you then please remove the page selection from above the results?

[Koc]

@Chartman123 removed