feat: make full-text search case-insensitive and search by submission author as well#2761
Merged
Chartman123 merged 1 commit intomainfrom Jun 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
============================================
- Coverage 45.58% 45.48% -0.10%
- Complexity 984 987 +3
============================================
Files 79 79
Lines 3565 3586 +21
============================================
+ Hits 1625 1631 +6
- Misses 1940 1955 +15 🚀 New features to boost your workflow:
|
Chartman123
reviewed
Jun 8, 2025
Collaborator
Chartman123
left a comment
There was a problem hiding this comment.
I think the search should always do the placeholder search for consistency. On the other hand, I'm not really sure if we should really extend the filtering to the username.
Collaborator
Author
|
I've updated PR description with motivation of this change. |
… author as well Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
4bf3925 to
bd2a73a
Compare
Chartman123
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for the #2710. Previously (before pagination introduction) we were able to find submissions by username just by pressing
ctrl+fin a browser. Let's make it possible with server-side pagination as well to not degrade in functionality.