Skip to content

feat: make full-text search case-insensitive and search by submission author as well#2761

Merged
Chartman123 merged 1 commit intomainfrom
feature/improve-search-submissions
Jun 20, 2025
Merged

feat: make full-text search case-insensitive and search by submission author as well#2761
Chartman123 merged 1 commit intomainfrom
feature/improve-search-submissions

Conversation

@Koc
Copy link
Copy Markdown
Collaborator

@Koc Koc commented Jun 8, 2025

Follow-up for the #2710. Previously (before pagination introduction) we were able to find submissions by username just by pressing ctrl+f in a browser. Let's make it possible with server-side pagination as well to not degrade in functionality.

@Koc Koc requested review from Chartman123 and susnux June 8, 2025 14:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.48%. Comparing base (09d7d59) to head (bd2a73a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2761      +/-   ##
============================================
- Coverage     45.58%   45.48%   -0.10%     
- Complexity      984      987       +3     
============================================
  Files            79       79              
  Lines          3565     3586      +21     
============================================
+ Hits           1625     1631       +6     
- Misses         1940     1955      +15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the search should always do the placeholder search for consistency. On the other hand, I'm not really sure if we should really extend the filtering to the username.

Comment thread lib/Db/SubmissionMapper.php Outdated
Comment thread lib/Db/SubmissionMapper.php Outdated
@Koc
Copy link
Copy Markdown
Collaborator Author

Koc commented Jun 8, 2025

I've updated PR description with motivation of this change.

… author as well

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/improve-search-submissions branch from 4bf3925 to bd2a73a Compare June 19, 2025 22:07
@Chartman123 Chartman123 merged commit 4cc988f into main Jun 20, 2025
54 checks passed
@Chartman123 Chartman123 deleted the feature/improve-search-submissions branch June 20, 2025 08:03
@Chartman123 Chartman123 added this to the 5.2 milestone Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants