Skip to content

[stable5.2] fix: prevent race conditions while creating options #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chartman123 merged 1 commit into from
Mar 17, 2026
Merged

[stable5.2] fix: prevent race conditions while creating options #3226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/components/Questions/AnswerInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,16 +278,24 @@ export default {
const answer = { ...this.answer }
answer.text = value

// Dispatched for creation. Marked as synced
this.$set(this.answer, 'local', false)
const newAnswer = await this.createAnswer(answer)
// Prevent any queued debounced PATCHes from running while creating
this.queue.pause()
try {
// Dispatched for creation. Marked as synced
this.$set(this.answer, 'local', false)
const newAnswer = await this.createAnswer(answer)

// Forward changes, but use current answer.text to avoid erasing
// any in-between changes while creating the answer
newAnswer.text = this.$refs.input.value
this.localText = ''
// Forward changes, but use current answer.text to avoid erasing
// any in-between changes while creating the answer
newAnswer.text = this.$refs.input.value
this.localText = ''

this.$emit('create-answer', this.index, newAnswer)
this.$emit('create-answer', this.index, newAnswer)
} finally {
// Clear pending update tasks (stale PATCHes) before resuming processing
this.queue.clear()
this.queue.start()
}
},

/**
Expand Down
Loading