Skip to content

feat: improve handling of option limits#3323

Merged
Chartman123 merged 1 commit into
mainfrom
enh/improve-limit-handling
May 19, 2026
Merged

feat: improve handling of option limits#3323
Chartman123 merged 1 commit into
mainfrom
enh/improve-limit-handling

Conversation

@Chartman123

Copy link
Copy Markdown
Collaborator

This closes #3257 by adding a NcNoteCard that shows the current limits. It also fixes a bug where the limits could be greater than the available options. If the lower limit is set, to question will automatically get required.

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket javascript Javascript related ticket labels May 5, 2026
@Chartman123 Chartman123 added this to the 5.3 milestone May 5, 2026
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label May 5, 2026
@Chartman123 Chartman123 self-assigned this May 5, 2026
@Chartman123 Chartman123 requested review from pringelmann and susnux May 5, 2026 18:54
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/FormsService.php 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123 Chartman123 force-pushed the enh/improve-limit-handling branch 3 times, most recently from c46fbe3 to feb1718 Compare May 12, 2026 14:38
Comment thread src/mixins/QuestionMixin.js
Comment thread src/components/Questions/Question.vue
@Chartman123 Chartman123 force-pushed the enh/improve-limit-handling branch from feb1718 to f124e69 Compare May 18, 2026 21:10
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the enh/improve-limit-handling branch from f124e69 to b8a559f Compare May 18, 2026 21:47
@Chartman123

Copy link
Copy Markdown
Collaborator Author

the infoId review comments are resolved now :) at least I think they are...

@Chartman123 Chartman123 merged commit 315505e into main May 19, 2026
53 checks passed
@Chartman123 Chartman123 deleted the enh/improve-limit-handling branch May 19, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No indication that option limits are set for checkbox questions

3 participants