fix(export): type numeric answers as numbers in exports#3368
Open
solracsf wants to merge 1 commit into
Open
Conversation
solracsf
added
bug
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
fix/numeric-as-numbers
branch
from
56abba2 to
e90d45e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
/backport to stable5.2 |
Member
Author
|
@Chartman123 we've manually backported it as codebase is not the same. |
Collaborator
|
You're absolutely right, my fault... so please re-open the manual backport :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radio and other choice-type answers are always PHP strings, even when the option labels are pure numbers like "1"-"5".
setCellValue()wrote every string viasetValueExplicit()with the defaultTYPE_STRING, so numeric answers landed in Text-formatted cells and could not be averaged in the spreadsheet application.For XLSX/ODS, route purely numeric values through
setCellValue()so they are stored with a numeric data type. A value is only treated as numeric when it isis_numeric(), does not start with a formula-trigger character (= + - @), and round-trips exactly((string)(+$value) === $value).The round-trip guard keeps leading-zero phone numbers, scientific notation, trailing-zero decimals and oversized ids as text to avoid silent data loss, since all export values arrive as strings from
Answer::getText().The anti-formula string protection and CSV escaping are unchanged.