fix: save question reorder on drop instead of during drag#3392
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Chartman123
approved these changes
Jun 8, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drag-and-drop reordering saved the wrong order to the backend, so reloading reverted to the old order. Two related causes:
changeevent, which fires repeatedly during the drag (before the new order is committed) instead of once on release. Switched toupdate, which fires once on drop.saveOptionsOrderreads the order from theoptionsprop, which only updates after the reordered array round-trips through the parent. Saving synchronously on drop still read the stale order. The drag now sets the existingdirtyOptionsTypeflag so the debounced watcher saves once the new order has settled, the same path the move up/down buttons already use.Checklist
3. to review, feature component)stable32)