Skip to content

fix: save question reorder on drop instead of during drag #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chartman123 merged 3 commits into from
Jun 8, 2026
+6 −6
Merged

fix: save question reorder on drop instead of during drag #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b1d56d
fix: save question reorder on drop instead of during drag
pringelmann Jun 8, 2026
f67613c
fix: save option reorder on drop instead of during drag
pringelmann Jun 8, 2026
6ea6cba
fix: save option reorder on drop via debounced watcher
pringelmann Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Questions/QuestionDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
handle=".option__drag-handle"
invertSwap
target=".sort-target"
@change="saveOptionsOrder('choice')"
@update="dirtyOptionsType = 'choice'"
@start="onDragStart"
@end="onDragEnd">
<TransitionGroup
Expand All @@ -65,7 +65,7 @@
<AnswerInput
v-for="(answer, index) in choices"
:key="answer.local ? 'option-local' : answer.id"
ref="input"

Check warning on line 68 in src/components/Questions/QuestionDropdown.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'input' is defined as ref, but never used
:answer="answer"
:formId="formId"
isDropdown
Expand Down
4 changes: 2 additions & 2 deletions src/components/Questions/QuestionGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
handle=".option__drag-handle"
invertSwap
target=".sort-target"
@change="saveOptionsOrder('column')"
@update="dirtyOptionsType = 'column'"
@start="onDragStart"
@end="onDragEnd">
<!-- Column input edit -->
Expand All @@ -112,7 +112,7 @@
<AnswerInput
v-for="(answer, index) in columns"
:key="answer.local ? 'option-local' : answer.id"
ref="input"

Check warning on line 115 in src/components/Questions/QuestionGrid.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'input' is defined as ref, but never used
:answer="answer"
:formId="formId"
:index="index"
Expand All @@ -139,7 +139,7 @@
handle=".option__drag-handle"
invertSwap
target=".sort-target"
@change="saveOptionsOrder('row')"
@update="dirtyOptionsType = 'row'"
@start="onDragStart"
@end="onDragEnd">
<TransitionGroup
Expand All @@ -150,7 +150,7 @@
<AnswerInput
v-for="(answer, index) in rows"
:key="answer.local ? 'option-local' : answer.id"
ref="input"

Check warning on line 153 in src/components/Questions/QuestionGrid.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'input' is defined as ref, but never used
:answer="answer"
:formId="formId"
:index="index"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Questions/QuestionMultiple.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
handle=".option__drag-handle"
invertSwap
target=".sort-target"
@change="saveOptionsOrder('choice')"
@update="dirtyOptionsType = 'choice'"
@start="onDragStart"
@end="onDragEnd">
<TransitionGroup
Expand All @@ -136,7 +136,7 @@
<AnswerInput
v-for="(answer, index) in choices"
:key="answer.local ? 'option-local' : answer.id"
ref="input"

Check warning on line 139 in src/components/Questions/QuestionMultiple.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'input' is defined as ref, but never used
:answer="answer"
:formId="formId"
:index="index"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Questions/QuestionRanking.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
handle=".option__drag-handle"
invertSwap
target=".sort-target"
@change="saveOptionsOrder('choice')"
@update="dirtyOptionsType = 'choice'"
@start="onDragStart"
@end="onDragEnd">
<TransitionGroup
Expand Down
2 changes: 1 addition & 1 deletion src/views/Create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
direction="vertical"
invertSwap
handle=".question__drag-handle"
@change="onQuestionOrderChange"
@update="onQuestionOrderChange"
@start="onDragStart"
@end="onDragEnd">
<TransitionGroup
Expand Down
Loading