chore: install rector#3405
Conversation
Chartman123
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Chartman123
force-pushed
the
chore/rector
branch
4 times, most recently
from
7f4413c to
7604615
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
chore/rector
branch
from
7604615 to
e054900
Compare
Chartman123
added
php
|
wow, nice! Do we want add it into pipeline? |
|
There's a workflow template here that runs rector once a week and creates a PR with the resulting changes. https://github.com/nextcloud/.github/blob/master/workflow-templates%2Frector-apply.yml However I didn't find an org template for adding it to the CI pipeline |
|
@pringelmann should we backport those changes to stable5.3? Would make backporting of following bugfixes for 5.3 easier, but on the other hand those are bigger changes than you'd normally expect in a patch release. |
|
@Chartman123 I think its fine. 5.3 is still very fresh, and it seems theres very low regression risk. Reduced future backport friction is worth it imo |
|
/backport to stable5.3 |
backportbot
Bot
removed
the
backport-request
3 participants
Install rector and use the following rules/sets:
Signed-off-by: GitHub noreply@github.com