Skip to content

fix: Fix unit selection in file type#3410

Open
Koc wants to merge 2 commits into
mainfrom
bugfix/fix-unit-selection
Open

fix: Fix unit selection in file type#3410
Koc wants to merge 2 commits into
mainfrom
bugfix/fix-unit-selection

Conversation

@Koc

@Koc Koc commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Closes #3408

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc self-assigned this Jun 10, 2026
@Chartman123

Chartman123 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Nice, thanks :) do we have to adjust the other @input's in the menu, too?

@Koc

Koc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

I thought about that as well 🤝 but it works fine with even with @input 🤷‍♂️ . So I've decided to reduce amount of changes.

If you want - I can adjust all of them, just say

@Chartman123

Copy link
Copy Markdown
Collaborator

Yes, would be nice :)

@input is no longer listed in the events section of the style guide. so might stop working sometime in the future :)

https://nextcloud-vue-components.netlify.app/#/Components/NcActions

Please also have a look at the custom file extensions, in my prod instance the field only takes numbers

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc

Koc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

@Chartman123 I did more changes, but...

  1. there are short answer question type that relies on event?.isComposing (used for Chineese/Japanese). Sorry, but I have no any idea how to combine this with update:modelValue, it seems like we still need @input for that
  2. extension selection not works for me. It works fine for vue-select but not works for Nextcloud wrapper

feel free to push to my branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit selection for files question not working correctly

2 participants