feat(httproute): add optional timeouts field#853
Open
Petersmit27 wants to merge 1 commit intonextcloud:mainfrom
Open
feat(httproute): add optional timeouts field#853Petersmit27 wants to merge 1 commit intonextcloud:mainfrom
Petersmit27 wants to merge 1 commit intonextcloud:mainfrom
Conversation
Signed-off-by: Peter Smit <petersmit27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
When using Gateway API's HTTPRoute, adds the option to configure the timeouts block (Gateway API docs)
I found that the setup check on Nextcloud's
/settings/admin/overviewpage times out because the request takes ~35 seconds. I run Envoy, which handles a 15 second timeout by default.Benefits
Allows for more customisation using standard features in the Gateway API spec. (nothing implementation-specific)
Possible drawbacks
Internal structure of the
timeoutsblock not declared and must be formed correctly in the values by the user. I figured this would be okay, since thematchesandfiltersblocks behave the same way and are more complex. Please let me know if this should be changed, however.Parameters are also not documented in the README, but so is the rest of the HTTPRoute setup...
Applicable issues
Additional information
And
helm template nextcloud charts/nextcloud --values examplevalues.yaml --show-only templates/route.yamlto generate the route. Applied this to my cluster and the request doesn't time out now.Bumped the chart a minor version because semver says I should bump "MINOR version when you add functionality in a backward compatible manner". Please let me know if that's OK in this case :)
Checklist
Chart.yamlaccording to semver.