Skip to content

Commit f89e699

Browse files
Implement review comments
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
1 parent 8cd50cf commit f89e699

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

lib/Service/GoogleCalendarAPIService.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ public function getCalendarList(string $userId): array {
6565
/**
6666
* @param string $userId
6767
* @param string $uri
68-
* @return ?string the calendar ID
68+
* @return ?int the calendar ID
6969
*/
70-
private function calendarExists(string $userId, string $uri): ?string {
70+
private function calendarExists(string $userId, string $uri): ?int {
7171
$res = $this->caldavBackend->getCalendarByUri('principals/users/' . $userId, $uri);
7272
return is_null($res)
7373
? null
@@ -103,13 +103,13 @@ private function mapTime(array $obj): string {
103103
/**
104104
* @param Event $e The event from which to generate the data.
105105
* @param array<Event> $events The collection of all events.
106-
* @param string $ncCalId The id of the event's calendar.
106+
* @param int $ncCalId The id of the event's calendar.
107107
* @param array $eventColors The event colors mapping.
108108
*/
109-
private function generateEventData(array $e, array $events, string $ncCalId, array $eventColors): string {
109+
private function generateEventData(array $e, array $events, int $ncCalId, array $eventColors): string {
110110
$eventData = 'BEGIN:VEVENT' . "\n";
111111

112-
$eventData .= 'UID:' . $ncCalId . '-' . $e['iCalUID'] . "\n";
112+
$eventData .= 'UID:' . strval($ncCalId) . '-' . $e['iCalUID'] . "\n";
113113
if (isset($e['colorId'], $eventColors[$e['colorId']], $eventColors[$e['colorId']]['background'])) {
114114
$closestCssColor = $this->getClosestCssColor($eventColors[$e['colorId']]['background']);
115115
$eventData .= 'COLOR:' . $closestCssColor . "\n";

0 commit comments

Comments
 (0)