Skip to content

Add log informing user of intentional delay in job execution#284

Merged
lukasdotcom merged 1 commit into
nextcloud:mainfrom
Bungeefan:job_delay_information
Oct 1, 2025
Merged

Add log informing user of intentional delay in job execution#284
lukasdotcom merged 1 commit into
nextcloud:mainfrom
Bungeefan:job_delay_information

Conversation

@Bungeefan
Copy link
Copy Markdown
Contributor

As discussed in #277:
While working on the feature, I discovered that the integration can delay the job execution without any information to the users.

This PR adds a simple log line with information when intentionally delaying the execution of the import job.

Feel free to change the message as you see fit, I just threw something together that had enough information for me while testing.

Off-topic: I also noticed that Nextcloud already provides a scheduling feature for jobs, maybe it would be worth it to switch to the native scheduling instead of manually re-scheduling the job every ~5 minutes.

@lukasdotcom
Copy link
Copy Markdown
Member

Hi @Bungeefan,

Looks good you just need to sign your commits with the -s flag. You can see more details by clicking on the DCO github action.

Signed-off-by: Severin Hamader <severin.hamader@yahoo.de>
@lukasdotcom lukasdotcom self-requested a review October 1, 2025 17:47
Copy link
Copy Markdown
Member

@lukasdotcom lukasdotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. I'll look at your other prs later as they will take a little longer to review. 🚀

@lukasdotcom lukasdotcom merged commit 1162712 into nextcloud:main Oct 1, 2025
20 checks passed
@Bungeefan Bungeefan deleted the job_delay_information branch October 1, 2025 19:15
@lukasdotcom lukasdotcom mentioned this pull request Oct 10, 2025
@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants