Skip to content

[master] refactor: separate team folder form into own component#1116

Open
backportbot[bot] wants to merge 22 commits into
masterfrom
backport/1093/master
Open

[master] refactor: separate team folder form into own component#1116
backportbot[bot] wants to merge 22 commits into
masterfrom
backport/1093/master

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Backport of PR #1093

saw-jan added 22 commits July 13, 2026 12:28
@saw-jan @backportbot
refactor(frontend): separate team folder admin form
374ddd6 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
refactor: remove unused code
633ee3f 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: add vue unit tests
4235dd3 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: form mode based on completeness
13573f8 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: add vue unit tests
dcdfc3c 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: setup error check based on props
9f82bcf 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: add error checks
e93cf3e 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: check project folder status while creating app-password
b36ae60 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: add vue unit tests
7af5bc7 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: app password to edit mode
f08ebde 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: fix AdminSettings unit tests
2d208af 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: use existing state
0141393 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: fix unit tests
0b01cdd 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
chore: add copyright info
2c4f9f8 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
chore: revert backend changes
ac0628a 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: form states
dc102ad 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: fix unit tests
a8797ef 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: form states
b67ab10 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: fix unit tests
a59d0e1 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
fix: form states
9a549e1 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
test: fix unit tests
3f010ee 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan @backportbot
chore: address reviews
6008293 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@backportbot backportbot Bot requested a review from nabim777 July 13, 2026 12:28
@backportbot backportbot Bot requested a review from saw-jan July 13, 2026 12:28
@backportbot backportbot Bot requested a review from Ashim-Stha as a code owner July 13, 2026 12:28
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

JS Code Coverage

Coverage after merging backport/1093/master into master will be
92.69%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js86.67%33.33%50%88.28%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js67.86%100%25%73.91%10–11, 18–19, 22–23
src/components
   AdminSettings.vue96.53%94.59%100%96.52%228–230, 248–250, 272–280
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOAuthSettings.vue97.61%96.15%93.10%98.10%217, 248, 338, 360, 378–380, 402–404
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormProjectFolder.vue96.56%92.71%97.56%97.22%265, 330, 330–332, 365, 365–366, 378–380, 396–399, 420–422, 479–481
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue98.99%95.65%100%99.41%107–108
   SearchInput.vue95.31%92.96%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.18%72.50%93.33%87.58%106–115, 128–130, 141–145, 155–157, 175–181, 219, 219–224, 224, 224–235, 80–81
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js93.85%93.33%88.89%94.24%100–102, 156–157, 23–25, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.18%86.32%90.48%95.43%367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

PHP Code Coverage

Coverage after merging backport/1093/master into master will be
67.91%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   ServerVersion.php0%100%0%0%17, 27–29, 32, 41–42
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php37.04%100%50%36%116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php79.01%100%70.59%79.36%114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 719, 722, 725–740, 754–757, 759–763
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php85.60%100%83.33%85.71%181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
   OpenProjectAPIController.php81.09%100%82.35%80.98%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php40%100%50%37.50%30, 38, 42–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
   UserLoggedInEventListener.php0%100%0%0%27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php0%100%0%0%100–101, 40–42, 51–58,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nabim777 nabim777 Awaiting requested review from nabim777 nabim777 is a code owner
@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner
@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner
@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner
@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner
@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner
@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner
@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner
@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan is a code owner
@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner
@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner
@Ashim-Stha Ashim-Stha Awaiting requested review from Ashim-Stha Ashim-Stha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@saw-jan saw-jan

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saw-jan