fix: Skip link check for empty message

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: kesselb

lib/Service/PhishingDetection/LinkCheck.php

@@ -49,10 +49,13 @@ private function parse(string $url): string {
 	}
 
 	public function run(string $htmlMessage) : PhishingDetectionResult {
-
 		$results = [];
 		$zippedArray = [];
 
+		if (empty($htmlMessage)) {
+			return $this->generateResult($results);
+		}
+
 		$dom = Parser::parseToDomDocument($htmlMessage);
 		$anchors = $dom->getElementsByTagName('a');
 		foreach ($anchors as $anchor) {
@@ -85,11 +88,24 @@ public function run(string $htmlMessage) : PhishingDetectionResult {
 				}
 			}
 		}
-		if (count($results) > 0) {
-			return new PhishingDetectionResult(PhishingDetectionResult::LINK_CHECK, true, $this->l10n->t('Some addresses in this message are not matching the link text'), $results);
+
+		return $this->generateResult($results);
+	}
+
+	private function generateResult(array $results): PhishingDetectionResult {
+		if ($results === []) {
+			return new PhishingDetectionResult(
+				PhishingDetectionResult::LINK_CHECK,
+				false
+			);
 		}
-		return  new PhishingDetectionResult(PhishingDetectionResult::LINK_CHECK, false);
 
+		return new PhishingDetectionResult(
+			PhishingDetectionResult::LINK_CHECK,
+			true,
+			$this->l10n->t('Some addresses in this message are not matching the link text'),
+			$results
+		);
 	}
 
 }

tests/Unit/Service/Phishing/LinkCheckTest.php

@@ -93,4 +93,11 @@ public function testAddressCasing(): void {
 		$result = $this->service->run($htmlMessage);
 		$this->assertFalse($result->isPhishing());
 	}
+
+	public function testEmptyMessage(): void {
+		$htmlMessage = '';
+
+		$result = $this->service->run($htmlMessage);
+		$this->assertFalse($result->isPhishing());
+	}
 }