fixup! feat: add delegation backend

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

Author: hamza221

lib/Db/DelegationMapper.php

@@ -30,28 +30,25 @@ public function findDelegatedAccountsForUser(string $uid): array {
 				$qb->expr()->eq('user_id', $qb->createNamedParameter($uid))
 			);
 
-		$rows = $this->findEntities($select);
-
-		return $rows;
+		return $this->findEntities($select);
 	}
 
-    public function findDelegatedToUsers(string $accountId) : array {
-        $qb = $this->db->getQueryBuilder();
+	public function findDelegatedToUsers(string $accountId): array {
+		$qb = $this->db->getQueryBuilder();
 
 		$select = $qb->select('user_id')
 			->from($this->getTableName())
 			->where(
 				$qb->expr()->eq('account_id', $qb->createNamedParameter($accountId))
 			);
 
-		$rows = $this->findEntities($select);
-		return $rows;
-    }
+		return $this->findEntities($select);
+	}
 
-    /**
+	/**
 	 * @throws DoesNotExistException
 	 */
-	public function find(int $accountId, string $uid): Actions {
+	public function find(int $accountId, string $uid): Delegation {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select('*')
 			->from($this->getTableName())

lib/Migration/Version5007Date20260312152753.php

@@ -11,6 +11,7 @@
 
 use Closure;
 use OCP\DB\ISchemaWrapper;
+use OCP\DB\Types;
 use OCP\Migration\IOutput;
 use OCP\Migration\SimpleMigrationStep;
 use Override;
@@ -41,18 +42,20 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 				'notnull' => true,
 				'length' => 64,
 			]);
+			$table->setPrimaryKey(['id']);
+			if ($schema->hasTable('mail_accounts')) {
+				$table->addForeignKeyConstraint(
+					$schema->getTable('mail_accounts'),
+					['account_id'],
+					['id'],
+					[
+						'onDelete' => 'CASCADE',
+					]
+				);
+			}
 		}
-		$table->setPrimaryKey(['id']);
-		if ($schema->hasTable('mail_accounts')) {
-			$table->addForeignKeyConstraint(
-				$schema->getTable('mail_accounts'),
-				['account_id'],
-				['id'],
-				[
-					'onDelete' => 'CASCADE',
-				]
-			);
-		}
+
+		return $schema;
 	}
 
 }

lib/Service/DelegationService.php

@@ -4,51 +4,46 @@
 
 /**
  * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
- * SPDX-License-Identifier: AGPL-3.0-only
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service;
 
+use OCA\Mail\Db\Delegation;
+use OCA\Mail\Db\DelegationMapper;
 use OCP\AppFramework\Db\DoesNotExistException;
 use Psr\Log\LoggerInterface;
-use OCA\Mail\Db\Delegation;
-use  OCA\Mail\Db\DelegationMapper;
 
 class DelegationService {
 
-
-    public function __construct(
-        private DelegationMapper $delegationMapper,
-        private LoggerInterface $logger
-    ){}
-
-    public function delegate(int $accountId, string $userId){
-        $delegation = new Delegation(); 
-        $delegation->setAccountId($accountId); 
-        $delegation->setUserId($userId);
-        $this->delegationMapper->insert($delegation);
-    }
-
-    public function findDelgatedAccountForUser(string $userId): array {
-        return $this->delegationMapper->findDelegatedAccountsForUser($userId);
-    }
-
-    public function findDelegatedToUsersForAccount(string $accountId): array {
-        return $this->delegationMapper->findDelegatedToUsers($accountId);
-    }
-
-    public function unDelegate(int $accountId, string $userId) {
-        try {
-            $delegation = $this->delegationMapper->find($accountId,$userId);
-
-        } catch (DoesNotExistException $e) {
-            $this->logger->warning("Delegation of account:$accountId not found for user: $userId", ['exception' => $e]);
-        }
-        if( !$delegation ){
-            return; 
-        }
-        $this->delegationMapper->delete($delegation);
-        
-    }
-
-}
+	public function __construct(
+		private DelegationMapper $delegationMapper,
+		private LoggerInterface $logger,
+	) {
+	}
+
+	public function delegate(int $accountId, string $userId): void {
+		$delegation = new Delegation();
+		$delegation->setAccountId($accountId);
+		$delegation->setUserId($userId);
+		$this->delegationMapper->insert($delegation);
+	}
+
+	public function findDelegatedAccountForUser(string $userId): array {
+		return $this->delegationMapper->findDelegatedAccountsForUser($userId);
+	}
+
+	public function findDelegatedToUsersForAccount(string $accountId): array {
+		return $this->delegationMapper->findDelegatedToUsers($accountId);
+	}
+
+	public function unDelegate(int $accountId, string $userId): void {
+		try {
+			$delegation = $this->delegationMapper->find($accountId, $userId);
+		} catch (DoesNotExistException $e) {
+			$this->logger->warning("Delegation of account:$accountId not found for user: $userId", ['exception' => $e]);
+			return;
+		}
+		$this->delegationMapper->delete($delegation);
+	}
+}