Skip to content

Commit a44b2bd

Browse files
committed
fix(thread): address review feedback on recipient CSS
- Nest .recipients inside .envelope__recipients (nested SCSS) - Replace magic numbers (60px, 38px, 4px) with CSS variable expressions: padding-inline-start aligns with sender name via border-radius-container + avatar width (10 * grid-baseline) + gap (2 * grid-baseline); padding-inline-end mirrors the container border-radius; gaps and padding-block use --default-grid-baseline Signed-off-by: sturlan <darko.sturlan@gmail.com>
1 parent 98f2f88 commit a44b2bd

1 file changed

Lines changed: 16 additions & 14 deletions

File tree

src/components/ThreadEnvelope.vue

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1399,24 +1399,26 @@ export default {
13991399
}
14001400
14011401
.envelope__recipients {
1402-
padding-inline: 60px 38px;
1403-
padding-block: 4px;
1402+
// align with sender name: header padding + avatar (40px) + gap (2 * grid-baseline)
1403+
padding-inline-start: calc(var(--border-radius-container) + var(--default-grid-baseline) * 12);
1404+
padding-inline-end: var(--border-radius-container);
1405+
padding-block: var(--default-grid-baseline);
14041406
display: flex;
14051407
flex-direction: column;
1406-
gap: 4px;
1407-
}
1408+
gap: var(--default-grid-baseline);
14081409
1409-
.recipients {
1410-
display: flex;
1411-
align-items: center;
1412-
flex-wrap: wrap;
1413-
gap: 4px;
1410+
.recipients {
1411+
display: flex;
1412+
align-items: center;
1413+
flex-wrap: wrap;
1414+
gap: var(--default-grid-baseline);
14141415
1415-
&__label {
1416-
color: var(--color-text-maxcontrast);
1417-
font-weight: bold;
1418-
white-space: nowrap;
1419-
min-width: 32px;
1416+
&__label {
1417+
color: var(--color-text-maxcontrast);
1418+
font-weight: bold;
1419+
white-space: nowrap;
1420+
min-width: 32px;
1421+
}
14201422
}
14211423
}
14221424

0 commit comments

Comments
 (0)