Merge pull request #12919 from nextcloud/fix/lint/no-console

ChristophWurst · web-flow · commit de964d8bf6ae · 2026-05-12T15:10:09.000+02:00
refactor: migrate console calls to logger
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -22,7 +22,7 @@ export default defineConfig([
 			},
 		},
 		rules: {
-			'no-console': 'warn',
+			'no-console': 'error',
 			'no-unused-vars': 'warn',
 
 			// 'jsdoc/no-undefined-types': 'error',
diff --git a/src/components/Composer.vue b/src/components/Composer.vue
@@ -1008,7 +1008,7 @@ export default {
 		},
 
 		aliases(newAliases) {
-			console.debug('aliases changed')
+			logger.debug('aliases changed')
 			if (this.selectedAlias === NO_ALIAS_SET) {
 				return
 			}
diff --git a/src/components/Envelope.vue b/src/components/Envelope.vue
@@ -717,7 +717,7 @@ export default {
 
 		hasMultipleRecipients() {
 			if (!this.account) {
-				console.error('account is undefined', {
+				logger.error('account is undefined', {
 					accountId: this.data.accountId,
 				})
 			}
diff --git a/src/components/MenuEnvelope.vue b/src/components/MenuEnvelope.vue
@@ -384,7 +384,7 @@ export default {
 
 		hasMultipleRecipients() {
 			if (!this.account) {
-				console.error('account is undefined', {
+				logger.error('account is undefined', {
 					accountId: this.envelope.accountId,
 				})
 			}
diff --git a/src/components/MessageAttachments.vue b/src/components/MessageAttachments.vue
@@ -136,7 +136,6 @@ export default {
 	},
 
 	mounted() {
-		console.log(this.attachments)
 		let prevTop = null
 		this.visible = 0
 		this.$nextTick(function() {
diff --git a/src/components/MessagePlainTextBody.vue b/src/components/MessagePlainTextBody.vue
@@ -77,8 +77,6 @@ export default {
 		},
 
 		signatureSummary() {
-			console.info(this.signature.match(regFirstParagraph))
-
 			return this.signatureSummaryAndBody.summary
 		},
 	},
diff --git a/src/components/NavigationAccount.vue b/src/components/NavigationAccount.vue
@@ -294,14 +294,14 @@ export default {
 
 		onMenuToggle(open) {
 			if (open && this.account.quotaPercentage !== null) {
-				console.debug('accounts menu opened, fetching quota')
+				logger.debug('accounts menu opened, fetching quota')
 				this.fetchQuota()
 			}
 		},
 
 		async fetchQuota() {
 			const quota = await fetchQuota(this.account.id)
-			console.debug('quota fetched', {
+			logger.debug('quota fetched', {
 				quota,
 			})
 
diff --git a/src/components/NavigationMailbox.vue b/src/components/NavigationMailbox.vue
@@ -727,7 +727,7 @@ export default {
 				this.renameInput = false
 			} catch (error) {
 				showInfo(t('mail', 'An error occurred, unable to rename the mailbox.'))
-				console.error(error)
+				logger.error('could not rename mailbox', { error })
 			} finally {
 				this.showSaving = false
 			}
diff --git a/src/components/NewMessageModal.vue b/src/components/NewMessageModal.vue
@@ -285,7 +285,7 @@ export default {
 				const sizePreference = this.mainStore.getPreference('modalSize')
 				this.largerModal = sizePreference === 'large'
 			} catch (error) {
-				console.error('Error getting modal size preference', error)
+				logger.error('Error getting modal size preference', { error })
 			}
 		},
 
@@ -298,7 +298,7 @@ export default {
 					value: this.largerModal ? 'large' : 'normal',
 				})
 			} catch (error) {
-				console.error('Failed to save preference', error)
+				logger.error('Failed to save preference', { error })
 			}
 		},
 
@@ -623,7 +623,7 @@ export default {
 				e.returnValue = true
 				this.mainStore.showMessageComposerMutation()
 			} else {
-				console.info('No unsaved changes. See you!')
+				logger.debug('no unsaved changes, closing')
 			}
 		},
 
diff --git a/src/components/RecipientBubble.vue b/src/components/RecipientBubble.vue
@@ -125,6 +125,7 @@ import IconClose from 'vue-material-design-icons/CloseOutline.vue'
 import IconDetails from 'vue-material-design-icons/InformationOutline.vue'
 import IconAdd from 'vue-material-design-icons/Plus.vue'
 import IconReply from 'vue-material-design-icons/ReplyOutline.vue'
+import logger from '../logger.js'
 import { fetchAvatarUrlMemoized } from '../service/AvatarService.js'
 import { addToContact, autoCompleteByName, findMatches, newContact } from '../service/ContactIntegrationService.js'
 
@@ -215,7 +216,7 @@ export default {
 		try {
 			this.avatarUrl = await fetchAvatarUrlMemoized(this.email)
 		} catch (error) {
-			console.debug('no avatar for ' + this.email, {
+			logger.debug('no avatar for ' + this.email, {
 				error,
 			})
 		}
@@ -258,11 +259,11 @@ export default {
 		onClickAddToContact() {
 			if (this.selection === ContactSelectionStateEnum.new) {
 				if (this.newContactName !== '') {
-					newContact(this.newContactName.trim(), this.email).then((res) => console.debug('ContactIntegration', res))
+					newContact(this.newContactName.trim(), this.email).then((res) => logger.debug('ContactIntegration', { res }))
 				}
 			} else if (this.selection === ContactSelectionStateEnum.existing) {
 				if (this.selectedContact) {
-					addToContact(this.selectedContact.id, this.email).then((res) => console.debug('ContactIntegration', res))
+					addToContact(this.selectedContact.id, this.email).then((res) => logger.debug('ContactIntegration', { res }))
 				}
 			}
 		},
diff --git a/src/components/TagItem.vue b/src/components/TagItem.vue
@@ -68,6 +68,7 @@ import { NcActionInput as ActionInput, NcActions as Actions, NcActionText as Act
 import { mapStores } from 'pinia'
 import IconEdit from 'vue-material-design-icons/PencilOutline.vue'
 import DeleteIcon from 'vue-material-design-icons/TrashCanOutline.vue'
+import logger from '../logger.js'
 import useMainStore from '../store/mainStore.js'
 import { translateTagDisplayName } from '../util/tag.js'
 
@@ -131,7 +132,7 @@ export default {
 				this.showSaving = false
 			} catch (error) {
 				showInfo(t('mail', 'An error occurred, unable to rename the tag.'))
-				console.error(error)
+				logger.error('could not rename tag', { error })
 				this.showSaving = true
 			}
 		},
@@ -159,7 +160,7 @@ export default {
 				this.showSaving = false
 			} catch (error) {
 				showInfo(t('mail', 'An error occurred, unable to rename the tag.'))
-				console.error(error)
+				logger.error('could not rename tag', { error })
 				this.renameTagLabel = false
 				this.renameTagInput = false
 				this.showSaving = true
diff --git a/src/components/TagModal.vue b/src/components/TagModal.vue
@@ -59,6 +59,7 @@ import IconAdd from 'vue-material-design-icons/Plus.vue'
 import IconTag from 'vue-material-design-icons/TagOutline.vue'
 import DeleteTagModal from './DeleteTagModal.vue'
 import TagItem from './TagItem.vue'
+import logger from '../logger.js'
 import useMainStore from '../store/mainStore.js'
 import { hiddenTags } from './tags.js'
 
@@ -179,7 +180,7 @@ export default {
 					color: randomColor(displayName),
 				})
 			} catch (error) {
-				console.debug(error)
+				logger.error('could not create tag', { error })
 				showError(this.t('mail', 'An error occurred, unable to create the tag.'))
 			} finally {
 				this.showSaving = false
@@ -223,7 +224,7 @@ export default {
 				this.showSaving = false
 			} catch (error) {
 				showInfo(t('mail', 'An error occurred, unable to rename the tag.'))
-				console.error(error)
+				logger.error('could not rename tag', { error })
 				this.renameTagLabel = false
 				this.renameTagInput = false
 				this.showSaving = true
diff --git a/src/components/TextEditor.vue b/src/components/TextEditor.vue
@@ -483,7 +483,7 @@ export default {
 							this.editorInstance.editing.view.focus()
 						})
 						.catch((error) => {
-							console.debug('Smart picker promise rejected:', error)
+							logger.debug('Smart picker promise rejected', { error })
 						})
 				}
 				if (eventData.marker === '@') {
diff --git a/src/components/Thread.vue b/src/components/Thread.vue
@@ -129,7 +129,7 @@ export default {
 		threadSubject() {
 			const thread = this.thread
 			if (thread.length === 0) {
-				console.warn('thread is empty')
+				logger.warn('thread is empty')
 				return ''
 			}
 			return thread[0].subject || this.t('mail', 'No subject')
@@ -188,10 +188,10 @@ export default {
 				return
 			}
 			if (!this.expandedThreads.includes(threadId)) {
-				console.debug(`expand thread ${threadId}`)
+				logger.debug(`expand thread ${threadId}`)
 				this.expandedThreads.push(threadId)
 			} else {
-				console.debug(`collapse thread ${threadId}`)
+				logger.debug(`collapse thread ${threadId}`)
 				this.expandedThreads = this.expandedThreads.filter((t) => t !== threadId)
 			}
 		},
diff --git a/src/components/ThreadEnvelope.vue b/src/components/ThreadEnvelope.vue
@@ -583,7 +583,7 @@ export default {
 
 		hasMultipleRecipients() {
 			if (!this.account) {
-				console.error('account is undefined', {
+				logger.error('account is undefined', {
 					accountId: this.envelope.accountId,
 				})
 			}
diff --git a/src/components/TranslationModal.vue b/src/components/TranslationModal.vue
@@ -88,6 +88,7 @@ import { mapState } from 'pinia'
 import WarningIcon from 'vue-material-design-icons/AlertOctagonOutline.vue'
 import ArrowRight from 'vue-material-design-icons/ArrowRight.vue'
 import ContentCopy from 'vue-material-design-icons/ContentCopy.vue'
+import logger from '../logger.js'
 import { translateText } from '../service/translationService.js'
 import useMainStore from '../store/mainStore.js'
 
@@ -175,7 +176,7 @@ export default {
 				const response = await translateText(this.message.trim(), this.selectedFrom.value, this.selectedTo.value)
 				this.translatedMessage = response
 			} catch (error) {
-				console.error(error)
+				logger.error('could not translate message', { error })
 				showError(error.response?.data?.ocs?.data?.message ?? t('mail', 'The message could not be translated'))
 			} finally {
 				this.isLoading = false
diff --git a/src/components/itinerary/CalendarImport.vue b/src/components/itinerary/CalendarImport.vue
@@ -27,6 +27,7 @@ import moment from '@nextcloud/moment'
 import { NcActionButton as ActionButton, NcActions as Actions, NcLoadingIcon as IconLoading } from '@nextcloud/vue'
 import ical from 'ical.js'
 import IconAdd from 'vue-material-design-icons/Plus.vue'
+import logger from '../../logger.js'
 
 export default {
 	name: 'CalendarImport',
@@ -63,7 +64,7 @@ export default {
 			calendar.loading = true
 
 			this.handler(calendar)
-				.catch(console.error.bind(this))
+				.catch((error) => logger.error('could not import calendar event', { error }))
 				.then(() => {
 					calendar.loading = false
 				})
diff --git a/src/i18n/MailboxTranslator.js b/src/i18n/MailboxTranslator.js
@@ -4,6 +4,7 @@
  */
 
 import { translate as t } from '@nextcloud/l10n'
+import logger from '../logger.js'
 
 function translateSpecial(mailbox) {
 	if (mailbox.specialUse.includes('all')) {
@@ -54,7 +55,7 @@ export function translate(mailbox) {
 		try {
 			return translateSpecial(mailbox)
 		} catch (e) {
-			console.error('could not translate special mailbox', e)
+			logger.error('could not translate special mailbox', { error: e })
 		}
 	}
 	return mailbox.displayName
diff --git a/src/init.js b/src/init.js
@@ -3,13 +3,14 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 import { loadState } from '@nextcloud/initial-state'
+import logger from './logger.js'
 import { fixAccountId } from './service/AccountService.js'
 import { fetchAvailableLanguages } from './service/translationService.js'
 import useMainStore from './store/mainStore.js'
 import useOutboxStore from './store/outboxStore.js'
 
 export default function initAfterAppCreation() {
-	console.debug('Init after app creation')
+	logger.debug('Init after app creation')
 	const mainStore = useMainStore()
 
 	const preferences = loadState('mail', 'preferences', [])
diff --git a/src/service/FileSharingService.js b/src/service/FileSharingService.js
@@ -9,6 +9,7 @@
 import axios from '@nextcloud/axios'
 import { showError } from '@nextcloud/dialogs'
 import { generateOcsUrl } from '@nextcloud/router'
+import logger from '../logger.js'
 
 /**
  * Makes a share link for a given file or directory.
@@ -33,11 +34,11 @@ async function shareFile(path, token) {
 			&& error.response.data.ocs.meta
 			&& error.response.data.ocs.meta.message
 		) {
-			console.error(`Error while sharing file: ${error.response.data.ocs.meta.message || 'Unknown error'}`)
+			logger.error(`Error while sharing file: ${error.response.data.ocs.meta.message || 'Unknown error'}`, { error })
 			showError(error.response.data.ocs.meta.message)
 			throw error
 		} else {
-			console.error('Error while sharing file: Unknown error')
+			logger.error('Error while sharing file: Unknown error', { error })
 			showError(t('mail', 'Error while sharing file'))
 			throw error
 		}
diff --git a/src/service/translationService.js b/src/service/translationService.js
@@ -5,6 +5,7 @@
 
 import axios from '@nextcloud/axios'
 import { generateOcsUrl } from '@nextcloud/router'
+import logger from '../logger.js'
 import useMainStore from '../store/mainStore.js'
 
 async function fetchAvailableLanguages() {
@@ -23,7 +24,7 @@ async function fetchAvailableLanguages() {
 		mainStore.translationInputLanguages = inputLanguages
 		mainStore.translationOutputLanguages = outputLanguages
 	} catch (e) {
-		console.error('Failed to fetch available languages', e)
+		logger.error('Failed to fetch available languages', { error: e })
 	}
 }
 
diff --git a/src/store/mainStore/actions.js b/src/store/mainStore/actions.js
diff --git a/src/task.js b/src/task.js
diff --git a/src/util/CrashReport.js b/src/util/CrashReport.js
diff --git a/src/views/Home.vue b/src/views/Home.vue

Original file line number	Diff line number	Diff line change
`@@ -1008,7 +1008,7 @@ export default {`
`1008`	`1008`	`},`
`1009`	`1009`
`1010`	`1010`	`aliases(newAliases) {`
`1011`		`- console.debug('aliases changed')`
	`1011`	`+ logger.debug('aliases changed')`
`1012`	`1012`	`if (this.selectedAlias === NO_ALIAS_SET) {`
`1013`	`1013`	`return`
`1014`	`1014`	`}`
Original file line number	Diff line number	Diff line change
`@@ -717,7 +717,7 @@ export default {`
`717`	`717`
`718`	`718`	`hasMultipleRecipients() {`
`719`	`719`	`if (!this.account) {`
`720`		`- console.error('account is undefined', {`
	`720`	`+ logger.error('account is undefined', {`
`721`	`721`	`accountId: this.data.accountId,`
`722`	`722`	`})`
`723`	`723`	`}`
Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ export default {`
`384`	`384`
`385`	`385`	`hasMultipleRecipients() {`
`386`	`386`	`if (!this.account) {`
`387`		`- console.error('account is undefined', {`
	`387`	`+ logger.error('account is undefined', {`
`388`	`388`	`accountId: this.envelope.accountId,`
`389`	`389`	`})`
`390`	`390`	`}`
Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,7 @@ export default {`
`727`	`727`	`this.renameInput = false`
`728`	`728`	`} catch (error) {`
`729`	`729`	`showInfo(t('mail', 'An error occurred, unable to rename the mailbox.'))`
`730`		`- console.error(error)`
	`730`	`+ logger.error('could not rename mailbox', { error })`
`731`	`731`	`} finally {`
`732`	`732`	`this.showSaving = false`
`733`	`733`	`}`