fix: add missing ImportantIcon and correct favorite/unfavorite bulk actions#12899
Open
RobinAngele wants to merge 2 commits intonextcloud:mainfrom
Open
fix: add missing ImportantIcon and correct favorite/unfavorite bulk actions#12899RobinAngele wants to merge 2 commits intonextcloud:mainfrom
RobinAngele wants to merge 2 commits intonextcloud:mainfrom
Conversation
…ctions - Add missing ImportantIcon import and component registration in EnvelopeList so the 'Mark as important' icon renders during bulk selection - Fix favorite/unfavorite bulk action logic: rename methods to favoriteAll/unfavoriteAll and use explicit favFlag values (true/false) instead of inverted computed checks that failed when all selected messages shared the same state AI-assisted: Cline (Claude) Signed-off-by: RobinAngele <robin@robin4consulting.com>
RobinAngele
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Thanks for opening your first pull request in this repository! ✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #12149
Changes
Missing ImportantIcon (refs #12149)
ImportantIconimport (vue-material-design-icons/LabelVariant.vue) and component registration inEnvelopeList.vueFavorite/unfavorite logic
favoriteAll()→unfavoriteAll(),unFavoriteAll()→favoriteAll()favFlag: true/favFlag: falseinstead of inverted computed checks (!this.isAtLeastOneSelectedX)favFlag = true(no-op). Now it always passes the correct flag.How to test