Change: Refactor FaviconDataAccess to use Nextclouds IClientService.#3671
Closed
Grotax wants to merge 1 commit into
Closed
Change: Refactor FaviconDataAccess to use Nextclouds IClientService.#3671Grotax wants to merge 1 commit into
Grotax wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SMillerDev
reviewed
Apr 8, 2026
Grotax
changed the title
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Apr 25, 2026
Changed - Replace direct Guzzle HTTP client usage with Nextcloud's `IClientService` for SSRF protection and automatic system proxy support (#3672, #3671, #3679) Fixed - Starred view fired an endless stream of requests due to a `fetchKey` mismatch between the component and the store (#3682) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor FaviconDataAccess to use Nextclouds IClientService.
Checklist