Release 28.4.1#3752
Merged
Merged
Conversation
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Added safety check for release process. Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the last release, the info.xml was not updated, due to the way how the release process works, this caused the new code to be released under the old version. Not that dramatic since the last version was a beta and functions the same as the stable release, but in other cases this could have negative consequences.
So I added a step that will fail the process, to create a release.
Checklist