fix: Refactored failing test.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>

Author: i2h3

Tests/NextcloudFileProviderKitTests/RemoteChangeObserverTests.swift

@@ -7,6 +7,7 @@ import NextcloudCapabilitiesKit
 @testable import NextcloudFileProviderKit
 import NextcloudFileProviderKitMocks
 import RealmSwift
+import Testing
 import TestInterface
 import XCTest
 
@@ -50,7 +51,7 @@ final class RemoteChangeObserverTests: NextcloudFileProviderKitTestCase {
 
     /// Helper to wait for an expectation with a standard timeout.
     private func wait(for expectation: XCTestExpectation, description: String) async {
-        let result = await XCTWaiter.fulfillment(of: [expectation], timeout: 5.0)
+        let result = await XCTWaiter.fulfillment(of: [expectation], timeout: 10.0)
         if result != .completed {
             XCTFail("Timeout waiting for \(description)")
         }
@@ -402,27 +403,14 @@ final class RemoteChangeObserverTests: NextcloudFileProviderKitTestCase {
     }
 
     func testPinging() async throws {
+        let authenticated = expectation(description: "authenticated")
+        authenticated.assertForOverFulfill = false
+
         let remoteInterface = MockRemoteInterface(account: Self.account)
         remoteInterface.capabilities = mockCapabilities
 
-        actor AuthFlag {
-            var value = false
-            func set() {
-                value = true
-            }
-
-            func get() -> Bool {
-                value
-            }
-        }
-        let authenticated = AuthFlag()
-
-        NotificationCenter.default.addObserver(
-            forName: NotifyPushAuthenticatedNotificationName, object: nil, queue: nil
-        ) { _ in
-            Task {
-                await authenticated.set()
-            }
+        NotificationCenter.default.addObserver(forName: NotifyPushAuthenticatedNotificationName, object: nil, queue: nil) { _ in
+            authenticated.fulfill()
         }
 
         remoteChangeObserver = RemoteChangeObserver(
@@ -437,20 +425,14 @@ final class RemoteChangeObserverTests: NextcloudFileProviderKitTestCase {
         let pingIntervalNsecs = 500_000_000
         remoteChangeObserver?.setWebSocketPingInterval(to: UInt64(pingIntervalNsecs))
 
-        for _ in 0 ... Self.timeout {
-            try await Task.sleep(nanoseconds: 1_000_000)
-            if await authenticated.get() {
-                break
-            }
-        }
-        let isAuthenticated = await authenticated.get()
-        XCTAssertTrue(isAuthenticated)
+        await fulfillment(of: [authenticated])
 
         let intendedPings = 3
         // Add a bit of buffer to the wait time
         let intendedPingsWait = (intendedPings + 1) * pingIntervalNsecs
 
         var pings = 0
+
         Self.notifyPushServer.pingHandler = {
             pings += 1
         }