Skip to content

Commit 9d24b70

Browse files
committed
Avoid repetition of metadata.lock check in each if
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
1 parent ad0ac2c commit 9d24b70

1 file changed

Lines changed: 15 additions & 13 deletions

File tree

Sources/NextcloudFileProviderKit/Item/Item.swift

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,22 @@ public class Item: NSObject, NSFileProviderItem {
4343
} else if permissions.contains("G") {
4444
capabilities.insert(.allowsReading)
4545
}
46-
if permissions.contains("D"), !metadata.lock { // Deletable
47-
capabilities.insert(.allowsDeleting)
48-
}
49-
if remoteSupportsTrash, !isLockFileName(filename), !metadata.lock {
50-
capabilities.insert(.allowsTrashing)
51-
}
52-
if permissions.contains("W"), !metadata.directory, !metadata.lock { // Updateable (file)
53-
capabilities.insert(.allowsWriting)
54-
}
55-
if permissions.contains("NV"), !metadata.lock { // Updateable, renameable, moveable
56-
capabilities.formUnion([.allowsRenaming, .allowsReparenting])
46+
if !metadata.lock {
47+
if permissions.contains("D") { // Deletable
48+
capabilities.insert(.allowsDeleting)
49+
}
50+
if remoteSupportsTrash, !isLockFileName(filename) {
51+
capabilities.insert(.allowsTrashing)
52+
}
53+
if permissions.contains("W"), !metadata.directory { // Updateable (file)
54+
capabilities.insert(.allowsWriting)
55+
}
56+
if permissions.contains("NV") { // Updateable, renameable, moveable
57+
capabilities.formUnion([.allowsRenaming, .allowsReparenting])
5758

58-
if metadata.directory {
59-
capabilities.insert(.allowsAddingSubItems)
59+
if metadata.directory {
60+
capabilities.insert(.allowsAddingSubItems)
61+
}
6062
}
6163
}
6264
// .allowsEvicting deprecated on macOS 13.0+, use contentPolicy instead

0 commit comments

Comments
 (0)