Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces SwiftFormat as a code formatting tool to standardize the Swift code style across the NextcloudFileProviderKit project. SwiftFormat automatically formats the codebase according to predefined rules, ensuring consistent style and improved readability.
- Adds SwiftFormat configuration and CI workflow
- Applies automated formatting changes across the entire codebase
- Updates documentation to include code style guidelines
Reviewed Changes
Copilot reviewed 71 out of 72 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .swiftformat | SwiftFormat configuration file |
| .github/workflows/swiftformat.yml | CI workflow to enforce formatting |
| Package.swift | Adds SwiftFormat as a dependency |
| README.md | Updates documentation with formatting instructions |
| Multiple Swift files | Automated formatting changes (import reordering, spacing, trailing commas, etc.) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
74ecd5d to
f848d99
Compare
camilasan
approved these changes
Oct 16, 2025
This is a dedicated commit to clearly separate the pure formatting changes from the actual SwiftFormat introduction. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Unused result values, mutable variables which never are altered, unused declarations, and variables being written to but never read. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
f848d99 to
17de41f
Compare
Collaborator
Author
|
I fixed the minor compiler errors and Xcode code style warnings since last approval. |
camilasan
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.