Skip to content

Fix crashing in MockRemoteInterfaceTests by ensuring remoteInterface is retained#67

Merged
claucambra merged 1 commit into
mainfrom
bugfix/mockremoteinterface-tests
Apr 25, 2025
Merged

Fix crashing in MockRemoteInterfaceTests by ensuring remoteInterface is retained#67
claucambra merged 1 commit into
mainfrom
bugfix/mockremoteinterface-tests

Conversation

@claucambra
Copy link
Copy Markdown
Contributor

No description provided.

…is retained

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 2.1 milestone Apr 25, 2025
@claucambra claucambra requested a review from Copilot April 25, 2025 10:45
@claucambra claucambra self-assigned this Apr 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a crash in MockRemoteInterfaceTests by ensuring that remoteInterface is retained throughout each test.

  • Added debugPrint(remoteInterface) statements in multiple tests
  • The changes aim to prevent premature deallocation of remoteInterface during test execution

Comment thread Tests/InterfaceTests/MockRemoteInterfaceTests.swift
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.67%. Comparing base (815c3ea) to head (433c2d7).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files          61       61           
  Lines       12696    12696           
=======================================
  Hits        10369    10369           
  Misses       2327     2327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claucambra claucambra merged commit 28e8e94 into main Apr 25, 2025
3 checks passed
@Rello Rello deleted the bugfix/mockremoteinterface-tests branch August 15, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants