Fix ignored files behaviour#68
Merged
Merged
Conversation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the behavior for ignored files by updating error handling and modifying unuploaded item creation.
- Updated test assertions to validate different outcomes on macOS 13.0 versus earlier versions.
- Refactored modifyUnuploaded to return an Item? instead of a tuple and adjusted related invocations in lock file and modify workflows.
- Introduced a new createUnuploaded function for handling previously unuploaded items.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/NextcloudFileProviderKitTests/ItemModifyTests.swift | Adjusted test expectations for ignored file behavior on macOS 13.0. |
| Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift | Updated method signature and logic; contains duplicated conditional bindings that need review. |
| Sources/NextcloudFileProviderKit/Item/Item+ModifyLockFile.swift | Changed lock file modification to use createUnuploaded when lock file status is lost. |
| Sources/NextcloudFileProviderKit/Item/Item+Modify.swift | Updated ignored file handling flow to accommodate the refactored modifyUnuploaded. |
| Sources/NextcloudFileProviderKit/Item/Item+CreateUnuploaded.swift | New functionality to create items that were previously unuploaded. |
Comments suppressed due to low confidence (2)
Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift:55
- Duplicate conditional binding for newCreationDate detected. Remove the redundant ', let newCreationDate' to ensure the condition is specified only once.
if changedFields.contains(.creationDate), let newCreationDate = itemTarget.creationDate, let newCreationDate
Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift:61
- Duplicate conditional binding for newModificationDate detected. Remove the redundant ', let newModificationDate' to correct the syntax.
if changedFields.contains(.contentModificationDate), let newModificationDate = itemTarget.contentModificationDate, let newModificationDate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 81.61% 81.58% -0.03%
==========================================
Files 61 62 +1
Lines 12835 12882 +47
==========================================
+ Hits 10475 10510 +35
- Misses 2360 2372 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.