Skip to content

Fix ignored files behaviour#68

Merged
claucambra merged 8 commits into
mainfrom
bugfix/ignore-files
Apr 25, 2025
Merged

Fix ignored files behaviour#68
claucambra merged 8 commits into
mainfrom
bugfix/ignore-files

Conversation

@claucambra
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 2.1 milestone Apr 25, 2025
@claucambra claucambra requested a review from Copilot April 25, 2025 10:50
@claucambra claucambra self-assigned this Apr 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the behavior for ignored files by updating error handling and modifying unuploaded item creation.

  • Updated test assertions to validate different outcomes on macOS 13.0 versus earlier versions.
  • Refactored modifyUnuploaded to return an Item? instead of a tuple and adjusted related invocations in lock file and modify workflows.
  • Introduced a new createUnuploaded function for handling previously unuploaded items.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Tests/NextcloudFileProviderKitTests/ItemModifyTests.swift Adjusted test expectations for ignored file behavior on macOS 13.0.
Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift Updated method signature and logic; contains duplicated conditional bindings that need review.
Sources/NextcloudFileProviderKit/Item/Item+ModifyLockFile.swift Changed lock file modification to use createUnuploaded when lock file status is lost.
Sources/NextcloudFileProviderKit/Item/Item+Modify.swift Updated ignored file handling flow to accommodate the refactored modifyUnuploaded.
Sources/NextcloudFileProviderKit/Item/Item+CreateUnuploaded.swift New functionality to create items that were previously unuploaded.
Comments suppressed due to low confidence (2)

Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift:55

  • Duplicate conditional binding for newCreationDate detected. Remove the redundant ', let newCreationDate' to ensure the condition is specified only once.
if changedFields.contains(.creationDate), let newCreationDate = itemTarget.creationDate, let newCreationDate

Sources/NextcloudFileProviderKit/Item/Item+ModifyUnuploaded.swift:61

  • Duplicate conditional binding for newModificationDate detected. Remove the redundant ', let newModificationDate' to correct the syntax.
if changedFields.contains(.contentModificationDate), let newModificationDate = itemTarget.contentModificationDate, let newModificationDate

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 72.44094% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (bbf1bf2) to head (e68b0a3).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...udFileProviderKit/Item/Item+CreateUnuploaded.swift 48.71% 20 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Modify.swift 76.00% 6 Missing ⚠️
...loudFileProviderKit/Item/Item+ModifyLockFile.swift 77.77% 4 Missing ⚠️
...udFileProviderKit/Item/Item+ModifyUnuploaded.swift 92.50% 3 Missing ⚠️
...extcloudFileProviderKitTests/ItemModifyTests.swift 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   81.61%   81.58%   -0.03%     
==========================================
  Files          61       62       +1     
  Lines       12835    12882      +47     
==========================================
+ Hits        10475    10510      +35     
- Misses       2360     2372      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claucambra claucambra merged commit 41c1a7f into main Apr 25, 2025
1 of 3 checks passed
@Rello Rello deleted the bugfix/ignore-files branch August 15, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants