Organise item-related extension files more sensibly#72
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes item‑related extensions in NextcloudFileProviderKit to improve code structure and maintainability. Key changes include:
- Renaming and updating the unuploaded item extension (Item+Unuploaded.swift) to better reflect its purpose.
- Adding a new trash management extension (Item+Trash.swift) and consolidating lock file operations into a single file (Item+LockFile.swift).
- Removing deprecated or redundant files (Item+ModifyLockFile.swift, Item+DeleteLockFile.swift, Item+CreateUnuploaded.swift, Item+CreateLockFile.swift) to streamline the codebase.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/NextcloudFileProviderKit/Item/Item+Unuploaded.swift | Updated header comment and added createUnuploaded() implementation adjustments. |
| Sources/NextcloudFileProviderKit/Item/Item+Trash.swift | New file adding trash() and restoreFromTrash() functions for managing trashed items. |
| Sources/NextcloudFileProviderKit/Item/Item+LockFile.swift | New file consolidating lock file creation, modification, and deletion functionalities. |
| Removed files (Item+ModifyLockFile.swift, Item+DeleteLockFile.swift, etc.) | Removed outdated implementations now replaced by reorganized extensions. |
Comments suppressed due to low confidence (1)
Sources/NextcloudFileProviderKit/Item/Item+LockFile.swift:2
- [nitpick] The header comment still references 'Item+CreateLockFile.swift' while the file is now named 'Item+LockFile.swift'; please update the comment to match the current file naming.
// Item+CreateLockFile.swift
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
claucambra
force-pushed
the
bugfix/organisation
branch
from
2565331 to
4f77c99
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 62 60 -2
Lines 13039 13040 +1
=======================================
+ Hits 10576 10577 +1
Misses 2463 2463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.